Merge pull request #8 from dipcode-software/feat/boundwidget

Added BoundWidget for widget options

Author: srtab

src/Fields/BoundField.php renamed to src/Bounds/BoundField.php

@@ -1,5 +1,5 @@
 <?php
-namespace PHPForm\Fields;
+namespace PHPForm\Bounds;
 
 use PHPForm\Config;
 
@@ -10,7 +10,7 @@ class BoundField
     private $form;
     private $field;
     private $name;
-    private $options_cache;
+    private $bound_widgets_cache;
 
     public $html_name;
     public $help_text;
@@ -55,18 +55,25 @@ public function __get($name)
         }
 
         if ($name == 'options') {
-            if (!isset($options_cache)) {
-                $options_cache = $this->getOptions();
+            if (!isset($bound_widgets_cache)) {
+                $bound_widgets_cache = $this->getSubWidgets();
             }
-            return $options_cache;
+            return $bound_widgets_cache;
         }
     }
 
-    private function getOptions(array $attrs = array())
+    private function getSubWidgets(array $attrs = array())
     {
+        $bounds = [];
+
         $attrs = $this->buildWidgetAttrs($attrs);
+        $options = $this->field->getWidget()->getOptions($this->html_name, $this->getValue(), $attrs);
+
+        foreach ($options as $option) {
+            $bounds[] = new BoundWidget($option);
+        }
 
-        return $this->field->getWidget()->getOptions($this->html_name, $this->getValue(), $attrs);
+        return $bounds;
     }
 
     protected function asWidget($widget = null, array $attrs = array())

src/Bounds/BoundWidget.php

@@ -0,0 +1,37 @@
+<?php
+namespace PHPForm\Bounds;
+
+use PHPForm\Config;
+
+class BoundWidget
+{
+    private $data;
+    private $template;
+
+    public $for;
+    public $type;
+    public $name;
+    public $value;
+    public $label;
+
+    public function __construct(array $data)
+    {
+        $this->for = $data["for"];
+        $this->type = $data["type"];
+        $this->name = $data["name"];
+        $this->value = $data["value"];
+        $this->label = $data["label"];
+        $this->template = $data["template"];
+
+        unset($data["template"]);
+
+        $this->data = $data;
+    }
+
+    public function __toString()
+    {
+        $renderer = Config::getInstance()->getRenderer();
+
+        return $renderer->render($this->template, $this->data);
+    }
+}

src/Config.php

@@ -37,7 +37,7 @@ class Config extends Singleton
      */
     public function setTemplatePack(string $template_pack)
     {
-        $this->template_packs = array_unshift($this->template_packs, $template_pack);
+        array_unshift($this->template_packs, $template_pack);
     }
 
     /**

src/Forms/Form.php

@@ -7,9 +7,9 @@
 use Iterator;
 use UnexpectedValueException;
 
+use PHPForm\Bounds\BoundField;
 use PHPForm\Errors\ErrorList;
 use PHPForm\Exceptions\ValidationError;
-use PHPForm\Fields\BoundField;
 
 abstract class Form implements ArrayAccess, Iterator, Countable
 {

src/Widgets/FileInput.php

@@ -32,10 +32,6 @@ public function formatValue($value)
      */
     public function valueFromData($data, $files, string $name)
     {
-        if (array_key_exists($name, $files)) {
-            return $files[$name];
-        }
-
-        return null;
+        return !is_null($files) && array_key_exists($name, $files) ? $files[$name] : null;
     }
 }

src/Widgets/Widget.php

@@ -94,7 +94,7 @@ protected function formatValue($value)
      */
     public function valueFromData($data, $files, string $name)
     {
-        return array_key_exists($name, $data) ? $data[$name] : null;
+        return !is_null($data) && array_key_exists($name, $data) ? $data[$name] : null;
     }
 
     /**

tests/unit/Fields/BoundFieldTest.php renamed to tests/unit/Bounds/BoundFieldTest.php

@@ -1,11 +1,12 @@
 <?php
-namespace PHPForm\Unit\Fields;
+namespace PHPForm\Unit\Bounds;
 
 use PHPUnit\Framework\TestCase;
 
+use PHPForm\Bounds\BoundField;
+use PHPForm\Bounds\BoundWidget;
 use PHPForm\Errors\ErrorList;
 use PHPForm\Exceptions\ValidationError;
-use PHPForm\Fields\BoundField;
 use PHPForm\Fields\CharField;
 use PHPForm\Fields\ChoiceField;
 use PHPForm\Widgets\RadioSelect;
@@ -214,16 +215,6 @@ public function testOptions()
         $field = new ChoiceField(["choices" => array("option1" => "Option1")]);
         $bound = new BoundField($this->simple_form, $field, "name");
 
-        $expected = array(array(
-            "for" => "id_name_1",
-            "type" => null,
-            "name" => "name",
-            "value" => "option1",
-            "label" => "Option1",
-            "attrs" => array(),
-            "template" => "select_option.html"
-        ));
-
-        $this->assertEquals($expected, $bound->options);
+        $this->assertInstanceOf(BoundWidget::class, $bound->options[0]);
     }
 }

tests/unit/Bounds/BoundWidgetTest.php

@@ -0,0 +1,44 @@
+<?php
+namespace PHPForm\Unit\Bounds;
+
+use PHPUnit\Framework\TestCase;
+
+use PHPForm\Bounds\BoundWidget;
+use PHPForm\Widgets\RadioSelect;
+
+class BoundWidgetTest extends TestCase
+{
+
+    protected function setUp()
+    {
+        $this->data = array(
+            "for" => "for",
+            "type" => "type",
+            "name" => "name",
+            "value" => "value",
+            "label" => "label",
+            "attrs" => array(),
+            "template" => RadioSelect::TEMPLATE_CHOICE,
+        );
+    }
+
+    public function testConstruct()
+    {
+        $bound = new BoundWidget($this->data);
+
+        $this->assertAttributeEquals("for", "for", $bound);
+        $this->assertAttributeEquals("type", "type", $bound);
+        $this->assertAttributeEquals("name", "name", $bound);
+        $this->assertAttributeEquals("value", "value", $bound);
+        $this->assertAttributeEquals("label", "label", $bound);
+        $this->assertAttributeEquals("radio_select_option.html", "template", $bound);
+    }
+
+    public function testToString()
+    {
+        $bound = new BoundWidget($this->data);
+
+        $expected = '<label for="for"><input name="name" type="type" value="value"/> label</label>';
+        $this->assertXmlStringEqualsXmlString((string) $bound, $expected);
+    }
+}

tests/unit/Forms/FormTest.php

@@ -4,7 +4,7 @@
 use PHPUnit\Framework\TestCase;
 
 use PHPForm\Forms\Form;
-use PHPForm\Fields\BoundField;
+use PHPForm\Bounds\BoundField;
 
 class FormTest extends TestCase
 {

tests/unit/Widgets/FileInputTest.php

@@ -39,4 +39,10 @@ public function testValueFromDataWithData()
         $value = $widget->valueFromData(array(), array("name" => "file"), "name");
         $this->assertEquals($value, "file");
     }
+
+    public function testValueFromDataWithNullData()
+    {
+        $widget = new FileInput();
+        $this->assertNull($widget->valueFromData(null, null, "name"));
+    }
 }