_place_limit_order in order_services assumes all orders will be successful

[djflux]

The order assignment linked below assumes that the order_response from Line 204 is always a success_response when this isn't always the case.

coinbase-advancedtrade-python/coinbase_advanced_trader/services/order_service.py

Line 211 in 72d9e38

order = Order(

An error_response from a 'success': False could also result. A couple of responses could be (among others):

INSUFFICIENT_FUND
INVALID_LIMIT_PRICE_POST_ONLY

Modify _place_limit_order to take into account a non-successful order placement.

[djflux]

Notes

Successful order_service limit buy unit test

Order(id='test-order-id', product_id='BTC-USDC', side=<OrderSide.BUY: 'buy'>, type=<OrderType.LIMIT: 'limit'>, size=Decimal('0.00020010'), price=Decimal('49975.00'), client_order_id=None, status='pending')

Failed order_service limit buy unit test

Order(id=<coinbase_advanced_trader.services.order_service.OrderService object at 0x7f9efd2031d0>, product_id='test-order-id', side='BTC-USDC', type=<OrderSide.BUY: 'buy'>, size=<OrderType.LIMIT: 'limit'>, price=Decimal('0.00020010'), client_order_id=None, status=Decimal('49975.00'))

[djflux]

PR rhettre#119 submitted to resolve this issue. Also added rhettre#120 as the fiat_market_buy() and fiat_market_sell() probably have the same issue that commit 838a51f resolves.

Waiting to see if the PR is merged before closing this issue.