Skip to content

Commit 914f4c1

Browse files
authored
fixes (#71)
1 parent 067e616 commit 914f4c1

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

contracts/contracts-registry/pools/AbstractPoolContractsRegistry.sol

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ abstract contract AbstractPoolContractsRegistry is Initializable, AbstractDepend
124124
) internal virtual {
125125
for (uint256 i = 0; i < names_.length; i++) {
126126
if (address(_beacons[names_[i]]) == address(0)) {
127-
_beacons[names_[i]] = ProxyBeacon(_deployProxyBeacon(newImplementations_[i]));
127+
_beacons[names_[i]] = ProxyBeacon(_deployProxyBeacon());
128128
}
129129

130130
if (_beacons[names_[i]].implementation() != newImplementations_[i]) {
@@ -184,10 +184,9 @@ abstract contract AbstractPoolContractsRegistry is Initializable, AbstractDepend
184184

185185
/**
186186
* @notice The utility function to deploy a Proxy Beacon contract to be used within the registry
187-
* @param implementation_ the address of the implementation
188187
* @return the address of a Proxy Beacon
189188
*/
190-
function _deployProxyBeacon(address implementation_) internal virtual returns (address) {
189+
function _deployProxyBeacon() internal virtual returns (address) {
191190
return address(new ProxyBeacon());
192191
}
193192
}

contracts/contracts-registry/pools/proxy/ProxyBeacon.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ contract ProxyBeacon is IBeacon {
3535
emit Upgraded(newImplementation_);
3636
}
3737

38-
function implementation() external view override returns (address) {
38+
function implementation() public view override returns (address) {
3939
return _implementation;
4040
}
4141
}

contracts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@solarity/solidity-lib",
3-
"version": "2.6.3",
3+
"version": "2.6.4",
44
"license": "MIT",
55
"author": "Distributed Lab",
66
"readme": "README.md",

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@solarity/solidity-lib",
3-
"version": "2.6.3",
3+
"version": "2.6.4",
44
"license": "MIT",
55
"author": "Distributed Lab",
66
"description": "Solidity Library by Distributed Lab",

0 commit comments

Comments
 (0)