Merge pull request #663 from glours/remove_completion_flag

Remove completion flag

Author: silvin-lubecki

README.md

@@ -353,7 +353,6 @@ A tool to build and manage Docker Applications.
 
 Commands:
   bundle      Create a CNAB invocation image and `bundle.json` for the application
-  completion  Generates completion scripts for the specified shell (bash or zsh)
   init        Initialize Docker Application definition
   inspect     Shows metadata, parameters and a summary of the Compose file for a given application
   install     Install an application

internal/commands/push.go

@@ -136,7 +136,7 @@ func pushInvocationImage(dockerCli command.Cli, retag retagResult) error {
 func pushBundle(dockerCli command.Cli, opts pushOptions, bndl *bundle.Bundle, retag retagResult) error {
 	insecureRegistries, err := insecureRegistriesFromEngine(dockerCli)
 	if err != nil {
-		return errors.Wrap(err, "could not retrive insecure registries")
+		return errors.Wrap(err, "could not retrieve insecure registries")
 	}
 	resolver := remotes.CreateResolver(dockerCli.ConfigFile(), insecureRegistries...)
 	var display fixupDisplay = &plainDisplay{out: os.Stdout}

internal/commands/root.go

@@ -17,7 +17,6 @@ import (
 )
 
 var (
-	completion  string
 	showVersion bool
 )
 
@@ -34,17 +33,6 @@ func NewRootCmd(use string, dockerCli command.Cli) *cobra.Command {
 				return nil
 			}
 
-			switch completion {
-			case "bash":
-				return cmd.GenBashCompletion(dockerCli.Out())
-			case "zsh":
-				return cmd.GenZshCompletion(dockerCli.Out())
-			default:
-				if completion != "" {
-					return fmt.Errorf("%q is not a supported shell\nSee 'docker app --help'", completion)
-				}
-			}
-
 			if len(args) != 0 {
 				return fmt.Errorf("%q is not a docker app command\nSee 'docker app --help'", args[0])
 			}
@@ -54,12 +42,6 @@ func NewRootCmd(use string, dockerCli command.Cli) *cobra.Command {
 	}
 	addCommands(cmd, dockerCli)
 
-	cmd.Flags().StringVar(&completion, "completion", "", "Generates completion scripts for the specified shell (bash or zsh)")
-	if err := cmd.Flags().MarkHidden("completion"); err != nil {
-		fmt.Fprintf(os.Stderr, "Failed to register command line options: %v", err.Error()) //nolint:errcheck
-		return nil
-	}
-
 	cmd.Flags().BoolVar(&showVersion, "version", false, "Print version information")
 	return cmd
 }