rm promisify calls

Author: LarryKlugerDS

.gitignore

@@ -5,6 +5,8 @@ npm-debug.log*
 yarn-debug.log*
 yarn-error.log*
 
+.idea/*
+
 # Runtime data
 pids
 *.pid

lib/examples/eg001EmbeddedSigning.js

@@ -8,7 +8,6 @@ const path = require('path')
     , fs = require('fs-extra')
     , docusign = require('docusign-esign')
     , validator = require('validator')
-    , {promisify} = require('util') // http://2ality.com/2017/05/util-promisify.html
     , dsConfig = require('../../ds_configuration.js').config
     ;
 
@@ -23,29 +22,6 @@ const eg001EmbeddedSigning = exports
     , dsPingUrl = dsConfig.appUrl + '/' // Url that will be pinged by the DocuSign Signing Ceremony via Ajax
     ;
 
-/**
- * Form page for this application
- */
-eg001EmbeddedSigning.getController = (req, res) => {
-    // Check that the authentication token is ok with a long buffer time.
-    // If needed, now is the best time to ask the user to authenticate
-    // since they have not yet entered any information into the form.
-    let tokenOK = req.dsAuthCodeGrant.checkToken();
-    if (tokenOK) {
-        res.render('pages/examples/eg001EmbeddedSigning', {
-            csrfToken: req.csrfToken(), 
-            title: "Embedded Signing Ceremony",
-            sourceFile: path.basename(__filename),
-            sourceUrl: dsConfig.githubExampleUrl + path.basename(__filename),
-            documentation: dsConfig.documentation + eg,
-            showDoc: dsConfig.documentation
-        });
-    } else {
-        // Save the current operation so it will be resumed after authentication
-        req.dsAuthCodeGrant.setEg(req, eg);
-        res.redirect(mustAuthenticate);
-    }
-}  
 
 /**
  * Create the envelope, the Signing Ceremony, and then redirect to the Signing Ceremony
@@ -125,7 +101,6 @@ eg001EmbeddedSigning.createController = async (req, res) => {
 // ***DS.worker.start ***DS.snippet.1.start
 eg001EmbeddedSigning.worker = async (args) => {
     let envelopesApi = new docusign.EnvelopesApi(args.dsAPIclient)
-      , createEnvelopeP = promisify(envelopesApi.createEnvelope).bind(envelopesApi)
       , results = null
       ;
 
@@ -134,19 +109,16 @@ eg001EmbeddedSigning.worker = async (args) => {
 
     // Step 2. call Envelopes::create API method
     // Exceptions will be caught by the calling function
-    results = await createEnvelopeP(args.accountId, {envelopeDefinition: envelope});
-    
+    results = await envelopesApi.createEnvelope(args.accountId, {envelopeDefinition: envelope});
+
     let envelopeId = results.envelopeId;
     console.log(`Envelope was created. EnvelopeId ${envelopeId}`);
 
     // Step 3. create the recipient view, the Signing Ceremony
-    let viewRequest = makeRecipientViewRequest(args.envelopeArgs)
-      , createRecipientViewP = promisify(envelopesApi.createRecipientView).bind(envelopesApi)
-      ;
-
+    let viewRequest = makeRecipientViewRequest(args.envelopeArgs);
     // Call the CreateRecipientView API
     // Exceptions will be caught by the calling function
-    results = await createRecipientViewP(args.accountId, envelopeId,
+    results = await envelopesApi.createRecipientView(args.accountId, envelopeId,
         {recipientViewRequest: viewRequest});
 
     return ({envelopeId: envelopeId, redirectUrl: results.url})
@@ -267,3 +239,27 @@ function makeRecipientViewRequest(args) {
 }
 // ***DS.snippet.3.end
 
+
+/**
+ * Form page for this application
+ */
+eg001EmbeddedSigning.getController = (req, res) => {
+    // Check that the authentication token is ok with a long buffer time.
+    // If needed, now is the best time to ask the user to authenticate
+    // since they have not yet entered any information into the form.
+    let tokenOK = req.dsAuthCodeGrant.checkToken();
+    if (tokenOK) {
+        res.render('pages/examples/eg001EmbeddedSigning', {
+            csrfToken: req.csrfToken(),
+            title: "Embedded Signing Ceremony",
+            sourceFile: path.basename(__filename),
+            sourceUrl: dsConfig.githubExampleUrl + path.basename(__filename),
+            documentation: dsConfig.documentation + eg,
+            showDoc: dsConfig.documentation
+        });
+    } else {
+        // Save the current operation so it will be resumed after authentication
+        req.dsAuthCodeGrant.setEg(req, eg);
+        res.redirect(mustAuthenticate);
+    }
+}

lib/examples/eg002SigningViaEmail.js

@@ -8,7 +8,6 @@ const path = require('path')
     , fs = require('fs-extra')
     , docusign = require('docusign-esign')
     , validator = require('validator')
-    , {promisify} = require('util') // http://2ality.com/2017/05/util-promisify.html
     , dsConfig = require('../../ds_configuration.js').config
     ;
 
@@ -23,29 +22,6 @@ const eg002SigningViaEmail = exports
     , dsPingUrl = dsConfig.appUrl + '/' // Url that will be pinged by the DocuSign Signing Ceremony via Ajax
     ;
 
-/**
- * Form page for this application
- */
-eg002SigningViaEmail.getController = (req, res) => {
-    // Check that the authentication token is ok with a long buffer time.
-    // If needed, now is the best time to ask the user to authenticate
-    // since they have not yet entered any information into the form.
-    let tokenOK = req.dsAuthCodeGrant.checkToken();
-    if (tokenOK) {
-        res.render('pages/examples/eg002SigningViaEmail', {
-            csrfToken: req.csrfToken(), 
-            title: "Signing request by email",
-            sourceFile: path.basename(__filename),
-            sourceUrl: dsConfig.githubExampleUrl + path.basename(__filename),
-            documentation: dsConfig.documentation + eg,
-            showDoc: dsConfig.documentation
-        });
-    } else {
-        // Save the current operation so it will be resumed after authentication
-        req.dsAuthCodeGrant.setEg(req, eg);
-        res.redirect(mustAuthenticate);
-    }
-}  
 
 /**
  * Create the envelope
@@ -127,7 +103,6 @@ eg002SigningViaEmail.createController = async (req, res) => {
 // ***DS.worker.start ***DS.snippet.1.start
 eg002SigningViaEmail.worker = async (args) => {
     let envelopesApi = new docusign.EnvelopesApi(args.dsAPIclient)
-      , createEnvelopeP = promisify(envelopesApi.createEnvelope).bind(envelopesApi)
       , results = null
       ;
 
@@ -136,7 +111,8 @@ eg002SigningViaEmail.worker = async (args) => {
 
     // Step 2. call Envelopes::create API method
     // Exceptions will be caught by the calling function
-    results = await createEnvelopeP(args.accountId, {envelopeDefinition: envelope});
+    results = await envelopesApi.createEnvelope(args.accountId,
+        {envelopeDefinition: envelope});
     let envelopeId = results.envelopeId;
 
     console.log(`Envelope was created. EnvelopeId ${envelopeId}`);
@@ -300,6 +276,31 @@ function document1(args) {
   }
   // ***DS.snippet.3.end
 
+/**
+ * Form page for this application
+ */
+eg002SigningViaEmail.getController = (req, res) => {
+    // Check that the authentication token is ok with a long buffer time.
+    // If needed, now is the best time to ask the user to authenticate
+    // since they have not yet entered any information into the form.
+    let tokenOK = req.dsAuthCodeGrant.checkToken();
+    if (tokenOK) {
+        res.render('pages/examples/eg002SigningViaEmail', {
+            csrfToken: req.csrfToken(),
+            title: "Signing request by email",
+            sourceFile: path.basename(__filename),
+            sourceUrl: dsConfig.githubExampleUrl + path.basename(__filename),
+            documentation: dsConfig.documentation + eg,
+            showDoc: dsConfig.documentation
+        });
+    } else {
+        // Save the current operation so it will be resumed after authentication
+        req.dsAuthCodeGrant.setEg(req, eg);
+        res.redirect(mustAuthenticate);
+    }
+}
+
+
 
 
 

lib/examples/eg003ListEnvelopes.js

@@ -8,7 +8,6 @@ const docusign = require('docusign-esign')
     , dsConfig = require('../../ds_configuration.js').config
     , moment = require('moment')
     , path = require('path')
-    , {promisify} = require('util') // http://2ality.com/2017/05/util-promisify.html
     ;
 
 const eg003ListEnvelopes = exports
@@ -17,30 +16,6 @@ const eg003ListEnvelopes = exports
     , minimumBufferMin = 3
     ;
 
-/**
- * Form page for this application
- */
-eg003ListEnvelopes.getController = (req, res) => {
-    // Check that the authentication token is ok with a long buffer time.
-    // If needed, now is the best time to ask the user to authenticate
-    // since they have not yet entered any information into the form.
-    let tokenOK = req.dsAuthCodeGrant.checkToken();
-    if (tokenOK) {
-        res.render('pages/examples/eg003ListEnvelopes', {
-            csrfToken: req.csrfToken(), 
-            title: "List envelopes",
-            sourceFile: path.basename(__filename),
-            sourceUrl: dsConfig.githubExampleUrl + path.basename(__filename),
-            documentation: dsConfig.documentation + eg,
-            showDoc: dsConfig.documentation
-        });
-    } else {
-        // Save the current operation so it will be resumed after authentication
-        req.dsAuthCodeGrant.setEg(req, eg);
-        res.redirect(mustAuthenticate);
-    }
-}  
-
 /**
  * List envelopes in the user's account
  * @param {object} req Request obj 
@@ -104,7 +79,6 @@ eg003ListEnvelopes.createController = async (req, res) => {
 // ***DS.worker.start ***DS.snippet.1.start
 eg003ListEnvelopes.worker = async (args) => {
     let envelopesApi = new docusign.EnvelopesApi(args.dsAPIclient)
-      , listStatusChangesP = promisify(envelopesApi.listStatusChanges).bind(envelopesApi)
       , results = null
       ;
 
@@ -119,8 +93,32 @@ eg003ListEnvelopes.worker = async (args) => {
     let options = {fromDate: moment().subtract(30, 'days').format()};
 
     // Exceptions will be caught by the calling function
-    results = await listStatusChangesP(args.accountId, options);
+    results = await envelopesApi.listStatusChanges(args.accountId, options);
     return results;
 }
 // ***DS.worker.end ***DS.snippet.1.end
 
+/**
+ * Form page for this application
+ */
+eg003ListEnvelopes.getController = (req, res) => {
+    // Check that the authentication token is ok with a long buffer time.
+    // If needed, now is the best time to ask the user to authenticate
+    // since they have not yet entered any information into the form.
+    let tokenOK = req.dsAuthCodeGrant.checkToken();
+    if (tokenOK) {
+        res.render('pages/examples/eg003ListEnvelopes', {
+            csrfToken: req.csrfToken(),
+            title: "List envelopes",
+            sourceFile: path.basename(__filename),
+            sourceUrl: dsConfig.githubExampleUrl + path.basename(__filename),
+            documentation: dsConfig.documentation + eg,
+            showDoc: dsConfig.documentation
+        });
+    } else {
+        // Save the current operation so it will be resumed after authentication
+        req.dsAuthCodeGrant.setEg(req, eg);
+        res.redirect(mustAuthenticate);
+    }
+}
+

lib/examples/eg004EnvelopeInfo.js

@@ -6,7 +6,6 @@
 
 const path = require('path')
     , docusign = require('docusign-esign')
-    , {promisify} = require('util') // http://2ality.com/2017/05/util-promisify.html
     , dsConfig = require('../../ds_configuration.js').config
     ;
 
@@ -16,30 +15,6 @@ const eg004EnvelopeInfo = exports
     , minimumBufferMin = 3
     ;
 
-/**
- * Form page for this application
- */
-eg004EnvelopeInfo.getController = (req, res) => {
-    // Check that the authentication token is ok with a long buffer time.
-    // If needed, now is the best time to ask the user to authenticate
-    // since they have not yet entered any information into the form.
-    let tokenOK = req.dsAuthCodeGrant.checkToken();
-    if (tokenOK) {
-        res.render('pages/examples/eg004EnvelopeInfo', {
-            csrfToken: req.csrfToken(), 
-            title: "Get envelope information",
-            envelopeOk: req.session.envelopeId,
-            sourceFile: path.basename(__filename),
-            sourceUrl: dsConfig.githubExampleUrl + path.basename(__filename),
-            documentation: dsConfig.documentation + eg,
-            showDoc: dsConfig.documentation
-        });
-    } else {
-        // Save the current operation so it will be resumed after authentication
-        req.dsAuthCodeGrant.setEg(req, eg);
-        res.redirect(mustAuthenticate);
-    }
-}  
 
 /**
  * Get the envelope
@@ -117,13 +92,38 @@ eg004EnvelopeInfo.createController = async (req, res) => {
 // ***DS.worker.start ***DS.snippet.1.start
 eg004EnvelopeInfo.worker = async (args) => {
     let envelopesApi = new docusign.EnvelopesApi(args.dsAPIclient)
-      , getEnvelopeP = promisify(envelopesApi.getEnvelope).bind(envelopesApi)
       , results = null
       ;
 
     // Step 1. Call Envelopes::get
     // Exceptions will be caught by the calling function
-    results = await getEnvelopeP(args.accountId, args.envelopeId, null);
+    results = await envelopesApi.getEnvelope(args.accountId, args.envelopeId, null);
     return results;
 }
-// ***DS.worker.end ***DS.snippet.1.end
+// ***DS.worker.end ***DS.snippet.1.end
+
+
+/**
+ * Form page for this application
+ */
+eg004EnvelopeInfo.getController = (req, res) => {
+    // Check that the authentication token is ok with a long buffer time.
+    // If needed, now is the best time to ask the user to authenticate
+    // since they have not yet entered any information into the form.
+    let tokenOK = req.dsAuthCodeGrant.checkToken();
+    if (tokenOK) {
+        res.render('pages/examples/eg004EnvelopeInfo', {
+            csrfToken: req.csrfToken(),
+            title: "Get envelope information",
+            envelopeOk: req.session.envelopeId,
+            sourceFile: path.basename(__filename),
+            sourceUrl: dsConfig.githubExampleUrl + path.basename(__filename),
+            documentation: dsConfig.documentation + eg,
+            showDoc: dsConfig.documentation
+        });
+    } else {
+        // Save the current operation so it will be resumed after authentication
+        req.dsAuthCodeGrant.setEg(req, eg);
+        res.redirect(mustAuthenticate);
+    }
+}