From 498ae684845e114b5cfe0b61c00c5a7896f11a2a Mon Sep 17 00:00:00 2001 From: Revin Guillen Date: Wed, 5 Jun 2013 09:04:00 -0700 Subject: [PATCH 1/2] Add ARIA role=presentation to ColumnSet-related DOM --- ColumnSet.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ColumnSet.js b/ColumnSet.js index 9a7ed66f1..5c7a0df80 100644 --- a/ColumnSet.js +++ b/ColumnSet.js @@ -133,11 +133,11 @@ function(kernel, declare, Deferred, listen, aspect, query, has, miscUtil, put, h }, columnSets: [], createRowCells: function(tag, each){ - var row = put("table.dgrid-row-table"); - var tr = put(row, "tbody tr"); + var row = put("table.dgrid-row-table[row=presentation]"); + var tr = put(row, "tbody tr[row=presentation]"); for(var i = 0, l = this.columnSets.length; i < l; i++){ // iterate through the columnSets - var cell = put(tr, tag + ".dgrid-column-set-cell.dgrid-column-set-" + i + + var cell = put(tr, tag + ".dgrid-column-set-cell.dgrid-column-set-" + i + "[row=presentation]" + " div.dgrid-column-set[" + colsetidAttr + "=" + i + "]"); cell.appendChild(this.inherited(arguments, [tag, each, this.columnSets[i]])); } From 7cb48e4033bd71bb1bc469b6a23dbad6a2f0eccf Mon Sep 17 00:00:00 2001 From: Revin Guillen Date: Tue, 11 Jun 2013 08:44:52 -0700 Subject: [PATCH 2/2] Fix typo'd attribute 'row' to 'role' --- ColumnSet.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ColumnSet.js b/ColumnSet.js index 5c7a0df80..8908778f4 100644 --- a/ColumnSet.js +++ b/ColumnSet.js @@ -133,11 +133,11 @@ function(kernel, declare, Deferred, listen, aspect, query, has, miscUtil, put, h }, columnSets: [], createRowCells: function(tag, each){ - var row = put("table.dgrid-row-table[row=presentation]"); - var tr = put(row, "tbody tr[row=presentation]"); + var row = put("table.dgrid-row-table[role=presentation]"); + var tr = put(row, "tbody tr[role=presentation]"); for(var i = 0, l = this.columnSets.length; i < l; i++){ // iterate through the columnSets - var cell = put(tr, tag + ".dgrid-column-set-cell.dgrid-column-set-" + i + "[row=presentation]" + + var cell = put(tr, tag + ".dgrid-column-set-cell.dgrid-column-set-" + i + "[role=presentation]" + " div.dgrid-column-set[" + colsetidAttr + "=" + i + "]"); cell.appendChild(this.inherited(arguments, [tag, each, this.columnSets[i]])); }