From 9fb85e70007b7975051a9575c29ca7f977dd7cb4 Mon Sep 17 00:00:00 2001 From: ashok-dominodatalab <66748560+ashok-dominodatalab@users.noreply.github.com> Date: Fri, 1 Aug 2025 12:27:24 -0700 Subject: [PATCH 1/6] Update MIGRATION.md --- examples/karpenter/MIGRATION.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/karpenter/MIGRATION.md b/examples/karpenter/MIGRATION.md index 4611b5021..39e481981 100644 --- a/examples/karpenter/MIGRATION.md +++ b/examples/karpenter/MIGRATION.md @@ -83,7 +83,7 @@ Given that karpenter itself is stateless, we set the `single_nodegroup` in order #### Implementation Steps -1. Add the following to the infra.tfvars and nodes.tfvars: +1. Check if the karpenter_node_groups variable exists then update or add it to the following to the infra.tfvars and nodes.tfvars: ```hcl # Consult the karpenter_node_groups variable for additional options. @@ -95,7 +95,7 @@ karpenter_node_groups = { } ``` -2. Add the following to the cluster.tfvars: +2. Check if the karpenter variable exists then update or add it to the cluster.tfvars: ```hcl # Consult the karpenter variable for additional options. @@ -214,7 +214,8 @@ If you do not wish to use the script to create and apply the `ec2nodeclasses` an 3. Apply the Karpenter configurations: ```bash -./karpenter/karpenter-configs.sh apply +cd karpenter +./karpenter-configs.sh apply ``` From 0b48828e169935a2c346848de0f6125234416d4b Mon Sep 17 00:00:00 2001 From: ashok-dominodatalab <66748560+ashok-dominodatalab@users.noreply.github.com> Date: Fri, 1 Aug 2025 18:24:57 -0700 Subject: [PATCH 2/6] Update karpenter-configs.sh added render for render option --- examples/karpenter/karpenter-configs.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/karpenter/karpenter-configs.sh b/examples/karpenter/karpenter-configs.sh index fa558026e..88e64ba01 100755 --- a/examples/karpenter/karpenter-configs.sh +++ b/examples/karpenter/karpenter-configs.sh @@ -145,6 +145,7 @@ check_directories case "$1" in "render") + render echo "Templates rendered successfully!" ;; "apply") From e580abc104f860ef219be5acc3ca83a8e109a59a Mon Sep 17 00:00:00 2001 From: ashok-dominodatalab <66748560+ashok-dominodatalab@users.noreply.github.com> Date: Fri, 1 Aug 2025 18:46:44 -0700 Subject: [PATCH 3/6] Update compute.yaml removed limits as its not part of v1 spec --- examples/karpenter/templates/nodepools/compute.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/karpenter/templates/nodepools/compute.yaml b/examples/karpenter/templates/nodepools/compute.yaml index 5936d8200..967df9efa 100644 --- a/examples/karpenter/templates/nodepools/compute.yaml +++ b/examples/karpenter/templates/nodepools/compute.yaml @@ -14,9 +14,9 @@ spec: dominodatalab.com/domino-node: "true" dominodatalab.com/node-pool: default spec: - limits: - cpu: 240 - memory: 960Gi +# limits: +# cpu: 240 +# memory: 960Gi expireAfter: Never nodeClassRef: group: karpenter.k8s.aws From fc6e40ffa7ddf9d46055ce9df8c32a6a1bbc4618 Mon Sep 17 00:00:00 2001 From: ashok-dominodatalab <66748560+ashok-dominodatalab@users.noreply.github.com> Date: Fri, 1 Aug 2025 18:46:59 -0700 Subject: [PATCH 4/6] Update gpu.yaml --- examples/karpenter/templates/nodepools/gpu.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/karpenter/templates/nodepools/gpu.yaml b/examples/karpenter/templates/nodepools/gpu.yaml index bedb53967..71c271401 100644 --- a/examples/karpenter/templates/nodepools/gpu.yaml +++ b/examples/karpenter/templates/nodepools/gpu.yaml @@ -15,10 +15,10 @@ spec: dominodatalab.com/node-pool: default-gpu nvidia.com/gpu: "true" spec: - limits: - cpu: 80 - memory: 320Gi - nvidia.com/gpu: 10 +# limits: +# cpu: 80 +# memory: 320Gi +# nvidia.com/gpu: 10 expireAfter: Never nodeClassRef: group: karpenter.k8s.aws From b1016dcd39bccf2bef5cd1864315775896496b55 Mon Sep 17 00:00:00 2001 From: ashok-dominodatalab <66748560+ashok-dominodatalab@users.noreply.github.com> Date: Fri, 1 Aug 2025 18:47:32 -0700 Subject: [PATCH 5/6] Update neuron.yaml removed limits --- examples/karpenter/templates/nodepools/neuron.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/karpenter/templates/nodepools/neuron.yaml b/examples/karpenter/templates/nodepools/neuron.yaml index fb78ce731..5a94496f7 100644 --- a/examples/karpenter/templates/nodepools/neuron.yaml +++ b/examples/karpenter/templates/nodepools/neuron.yaml @@ -15,10 +15,10 @@ spec: dominodatalab.com/domino-node: "true" dominodatalab.com/node-pool: trainium spec: - limits: - aws.amazon.com/neuron: 10 - cpu: 80 - memory: 320Gi +# limits: +# aws.amazon.com/neuron: 10 +# cpu: 80 +# memory: 320Gi expireAfter: Never nodeClassRef: group: karpenter.k8s.aws From d8ef45be4055367b3cf078af49ec6aad82ef6033 Mon Sep 17 00:00:00 2001 From: ashok-dominodatalab <66748560+ashok-dominodatalab@users.noreply.github.com> Date: Fri, 1 Aug 2025 18:47:46 -0700 Subject: [PATCH 6/6] Update platform.yaml removed limits --- examples/karpenter/templates/nodepools/platform.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/karpenter/templates/nodepools/platform.yaml b/examples/karpenter/templates/nodepools/platform.yaml index 10491ec56..5636e207c 100644 --- a/examples/karpenter/templates/nodepools/platform.yaml +++ b/examples/karpenter/templates/nodepools/platform.yaml @@ -14,9 +14,9 @@ spec: dominodatalab.com/domino-node: "true" dominodatalab.com/node-pool: platform spec: - limits: - cpu: 160 - memory: 640Gi +# limits: +# cpu: 160 +# memory: 640Gi expireAfter: Never nodeClassRef: group: karpenter.k8s.aws