Skip to content

Conversation

@akshay-zz
Copy link

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Fixes #63862 (in this specific format)

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 14, 2025
@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Oct 14, 2025
@akshay-zz
Copy link
Author

@akshay-zz the command you issued was incorrect. Please try again.

Examples are:

@dotnet-policy-service agree

and

@dotnet-policy-service agree company="your company"

@dotnet-policy-service agree

@akshay-zz
Copy link
Author

@dotnet-policy-service agree

@dotnet-policy-service agree

@akshay-zz akshay-zz changed the title Ignore 'From' when serializing a JsonPatchDocument for "add", "remove", "replace" and "test" operations Ignore "From" when serializing a JsonPatchDocument for "add", "remove", "replace" and "test" operations Oct 14, 2025
@gfoidl gfoidl added feature-json-patch area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Oct 15, 2025
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 22, 2025
@marcominerva
Copy link
Contributor

@akshay-zz could you please close and reopen this PR so that the validation can re-run? Your fix is important and should be merged.

@martincostello
Copy link
Member

Sorry, I thought I had permissions to do that, but turns out I can only close 😅

@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Nov 20, 2025
@marcominerva
Copy link
Contributor

So, please @akshay-zz reopen it 😅

@akshay-zz
Copy link
Author

I guess I don't have permission to reopen. I can push new commits to it and then open a new PR. @marcominerva

@marcominerva
Copy link
Contributor

Yes, please go ahead. 💪

@akshay-zz
Copy link
Author

#64457 @marcominerva . I'm not too confident about the PublicApi....txt changes. Please have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc community-contribution Indicates that the PR has been added by a community member feature-json-patch pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JsonPatch.SystemTextJson: When serializing a JsonPatchDocument, "from":null is incorrectly emitted for "add", "remove", "replace" and "test" operations.

5 participants