Skip to content

Ignore From when serializing a JsonPatchDocument for add, remove, rep… #64457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ignore From when serializing a JsonPatchDocument for add, remove, rep… #64457

wants to merge 2 commits into from
+29 −10

Conversation

@akshay-zz
Copy link

@akshay-zz akshay-zz commented Nov 20, 2025

Ignore "From" when serializing a JsonPatchDocument for "add", "remove", "replace" and "test" operations

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Fixes #63862 (in this specific format)

#64031 Pr got closed mistakenly by @martincostello. Creating new one as we don't have the right to reopen it.

@akshay-zz akshay-zz requested review from a team and tdykstra as code owners November 20, 2025 16:43
@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Nov 20, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 20, 2025
@akshay-zz akshay-zz mentioned this pull request Nov 20, 2025
Closed
4 tasks
@martincostello martincostello added feature-json-patch area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Nov 20, 2025
@tdykstra tdykstra requested review from wadepickett and removed request for tdykstra November 20, 2025 21:09
@wadepickett wadepickett removed their request for review November 20, 2025 22:04
@wadepickett wadepickett mentioned this pull request Nov 20, 2025
Open
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Nov 28, 2025

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc community-contribution Indicates that the PR has been added by a community member feature-json-patch pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JsonPatch.SystemTextJson: When serializing a JsonPatchDocument, "from":null is incorrectly emitted for "add", "remove", "replace" and "test" operations.

3 participants

@akshay-zz @martincostello @akumar806421