Adding documentation and tests that maxBy/minBy return the first max/min element (Array, List, Seq) #19140
+35
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added documentation and tests that maxBy/minBy return the first max/min element (Array, List, Seq).
Added tests that the first min/max element is returned (Array, List, Seq).
I wasn't able to add a test in
CollectionModulesConsistencybecause I wasn't sure how to add it there because of the data generator.!! I wasn't able to run the tests (fsx.exe not found in SDK 🤷) !!
I also cleaned up the exception docu on empty array/list/seq (once in the exceptions section, once as a remark).
I hope that helps 😃
Feel free to ignore, improve, change, take parts, ...
Fixes #19129
Checklist