Disallow RID on solution for MTP dotnet test (#50511)

Author: Youssef1313

src/Tasks/Microsoft.NET.Build.Extensions.Tasks/msbuildExtensions-ver/SolutionFile/ImportAfter/Microsoft.NET.Sdk.Solution.targets

@@ -21,7 +21,7 @@ Copyright (c) .NET Foundation. All rights reserved.
   ============================================================
    -->
   <Target Name="_CheckForSolutionLevelRuntimeIdentifier"
-          BeforeTargets="Build"
+          BeforeTargets="Build;_MTPBuild"
           Condition="'$(RuntimeIdentifier)' != ''">
 
     <NETSdkError ResourceName="CannotHaveSolutionLevelRuntimeIdentifier" />
@@ -30,7 +30,7 @@ Copyright (c) .NET Foundation. All rights reserved.
 
 
   <Target Name="_CheckForSolutionLevelOutputPath"
-          BeforeTargets="Build;Publish;Clean;Store;VSTest"
+          BeforeTargets="Build;Publish;Clean;Store;VSTest;_MTPBuild"
           Condition="'$(_CommandLineDefinedOutputPath)' == 'true'">
 
     <NetSdkWarning ResourceName="CannotHaveSolutionLevelOutputPath" />

test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTestsForMultipleTFMs.cs

@@ -161,15 +161,14 @@ public void RunProjectWithMultipleTFMsWithArchOption_ShouldReturnExitCodeGeneric
 
             if (!TestContext.IsLocalized())
             {
-                result.StdOut
-                    .Should().Contain("Test run summary: Failed!")
-                    .And.Contain("total: 14")
-                    .And.Contain("succeeded: 3")
-                    .And.Contain("failed: 8")
-                    .And.Contain("skipped: 3");
+                result.StdOut.Should().Contain("error NETSDK1134: Building a solution with a specific RuntimeIdentifier is not supported. If you would like to publish for a single RID, specify the RID at the individual project level instead.");
+            }
+            else
+            {
+                result.StdOut.Should().Contain("NETSDK1134");
             }
 
-            result.ExitCode.Should().Be(ExitCodes.AtLeastOneTestFailed);
+            result.ExitCode.Should().Be(ExitCodes.GenericFailure);
         }
 
         //  https://github.com/dotnet/sdk/issues/49665

test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs

@@ -218,7 +218,7 @@ public void RunWithNonExistentSolutionPath_ShouldReturnExitCodeGenericFailure(st
         [InlineData(TestingConstants.Debug)]
         [InlineData(TestingConstants.Release)]
         [PlatformSpecificTheory(TestPlatforms.Any & ~TestPlatforms.OSX)]
-        public void RunTestProjectSolutionWithArchOption_ShouldReturnExitCodeSuccess(string configuration)
+        public void RunTestProjectWithArchOption_ShouldReturnExitCodeSuccess(string configuration)
         {
             TestAsset testInstance = _testAssetsManager.CopyTestAsset("TestProjectWithTests", Guid.NewGuid().ToString()).WithSource();
 
@@ -235,6 +235,32 @@ public void RunTestProjectSolutionWithArchOption_ShouldReturnExitCodeSuccess(str
             result.ExitCode.Should().Be(ExitCodes.Success);
         }
 
+        //  https://github.com/dotnet/sdk/issues/49665
+        [InlineData(TestingConstants.Debug)]
+        [InlineData(TestingConstants.Release)]
+        [PlatformSpecificTheory(TestPlatforms.Any & ~TestPlatforms.OSX)]
+        public void RunTestProjectSolutionWithArchOption_NotSupported(string configuration)
+        {
+            TestAsset testInstance = _testAssetsManager.CopyTestAsset("TestProjectSolution", Guid.NewGuid().ToString()).WithSource();
+
+            var arch = RuntimeInformation.ProcessArchitecture.ToString().ToLowerInvariant();
+            CommandResult result = new DotnetTestCommand(Log, disableNewOutput: false)
+                                    .WithWorkingDirectory(testInstance.Path)
+                                    .Execute(CommonOptions.ArchitectureOption.Name, arch,
+                                             TestingPlatformOptions.ConfigurationOption.Name, configuration);
+
+            if (!TestContext.IsLocalized())
+            {
+                result.StdOut.Should().Contain("error NETSDK1134: Building a solution with a specific RuntimeIdentifier is not supported. If you would like to publish for a single RID, specify the RID at the individual project level instead.");
+            }
+            else
+            {
+                result.StdOut.Should().Contain("NETSDK1134");
+            }
+
+            result.ExitCode.Should().Be(ExitCodes.GenericFailure);
+        }
+
         //  https://github.com/dotnet/sdk/issues/49665
         [InlineData(TestingConstants.Debug)]
         [InlineData(TestingConstants.Release)]