Bug Fix: ArgumentNullException bug in gradient rendering

paulushub · paulushub · commit d92772e683ba · 2020-09-13T16:09:17.000+09:00
- Issue: Tests/Images/Dialog-information_red-test1.svg
- Issue: Tests/Images/molumen_red_square_error_warning_icon.svg
- Issue: Tests/Images/Images\router_andy_fitzsimon_r[1].svg
- Issue: Tests/Images/switch_cisco_nico_[1].svg
- Issue: Tests/Images/test1.svg
diff --git a/Source/SVGImage/SVG/PaintServer/GradientColorPaintServer.cs b/Source/SVGImage/SVG/PaintServer/GradientColorPaintServer.cs
@@ -28,7 +28,7 @@ public GradientColorPaintServer(PaintServerManager owner, XmlNode node) : base(o
             {
                 string refid = XmlUtil.AttrValue(node, "xlink:href", string.Empty);
                 string paintServerKey = owner.Parse(refid.Substring(1));
-                GradientColorPaintServer refcol = owner.GetServers()[paintServerKey] as GradientColorPaintServer;
+                GradientColorPaintServer refcol = owner.GetServer(paintServerKey) as GradientColorPaintServer;
                 if (refcol == null) return;
                 this.m_stops = new List<GradientStop>(refcol.m_stops);
             }
diff --git a/Source/SVGImage/SVG/PaintServer/LinearGradientColorPaintServer.cs b/Source/SVGImage/SVG/PaintServer/LinearGradientColorPaintServer.cs
@@ -1,6 +1,7 @@
-﻿using System.Windows;
+﻿using System.Xml;
+
+using System.Windows;
 using System.Windows.Media;
-using System.Xml;
 
 namespace SVGImage.SVG.PaintServer
 {
@@ -28,6 +29,7 @@ public LinearGradientColorPaintServerPaintServer(PaintServerManager owner, Brush
         {
             Brush = newBrush;
         }
+
         public override Brush GetBrush(double opacity, SVG svg, SVGRender svgRender, Rect bounds)
         {
             if (this.Brush != null) return this.Brush;
@@ -36,30 +38,30 @@ public override Brush GetBrush(double opacity, SVG svg, SVGRender svgRender, Rec
             foreach (GradientStop stop in this.Stops) b.GradientStops.Add(stop);
 
             b.MappingMode = BrushMappingMode.RelativeToBoundingBox;
-            b.StartPoint = new System.Windows.Point(0, 0);
-            b.EndPoint = new System.Windows.Point(1, 0);
+            b.StartPoint = new Point(0, 0);
+            b.EndPoint = new Point(1, 0);
             
             if (this.GradientUnits == SVGTags.sUserSpaceOnUse)
             {
                 Transform tr = this.Transform as Transform;
                 if (tr != null)
                 {
-                    b.StartPoint = tr.Transform(new System.Windows.Point(this.X1, this.Y1));
-                    b.EndPoint = tr.Transform(new System.Windows.Point(this.X2, this.Y2));
+                    b.StartPoint = tr.Transform(new Point(this.X1, this.Y1));
+                    b.EndPoint = tr.Transform(new Point(this.X2, this.Y2));
                 }
                 else
                 {
-                    b.StartPoint = new System.Windows.Point(this.X1, this.Y1);
-                    b.EndPoint = new System.Windows.Point(this.X2, this.Y2);
+                    b.StartPoint = new Point(this.X1, this.Y1);
+                    b.EndPoint = new Point(this.X2, this.Y2);
                 }
                 this.Transform = null;
                 b.MappingMode = BrushMappingMode.Absolute;
             }
             else
             {
                 this.Normalize();
-                if (double.IsNaN(this.X1) == false) b.StartPoint = new System.Windows.Point(this.X1, this.Y1);
-                if (double.IsNaN(this.X2) == false) b.EndPoint = new System.Windows.Point(this.X2, this.Y2);
+                if (double.IsNaN(this.X1) == false) b.StartPoint = new Point(this.X1, this.Y1);
+                if (double.IsNaN(this.X2) == false) b.EndPoint = new Point(this.X2, this.Y2);
             }
 
             this.Brush = b;
diff --git a/Source/SVGImage/SVG/PaintServer/PaintServerManager.cs b/Source/SVGImage/SVG/PaintServer/PaintServerManager.cs
@@ -37,11 +37,21 @@ public string Create(SVG svg, XmlNode node)
 
         public void AddServer(string key, PaintServer server)
         {
+            if (string.IsNullOrWhiteSpace(key))
+            {
+                return;
+            }
+
             m_servers[key] = server;
         }
 
         public PaintServer GetServer(string serverKey)
         {
+            if (string.IsNullOrWhiteSpace(serverKey))
+            {
+                return null;
+            }
+
             PaintServer result;
             if (serverKey != null && m_servers.TryGetValue(serverKey, out result)) return result;
             else return null;
diff --git a/Source/SVGImage/SVG/PaintServer/RadialGradientColorPaintServer.cs b/Source/SVGImage/SVG/PaintServer/RadialGradientColorPaintServer.cs
@@ -1,6 +1,7 @@
-﻿using System.Windows;
+﻿using System.Xml;
+
+using System.Windows;
 using System.Windows.Media;
-using System.Xml;
 
 namespace SVGImage.SVG.PaintServer
 {
@@ -40,15 +41,15 @@ public override Brush GetBrush(double opacity, SVG svg, SVGRender svgRender, Rec
             RadialGradientBrush b = new RadialGradientBrush();
             foreach (GradientStop stop in this.Stops) b.GradientStops.Add(stop);
 
-            b.GradientOrigin = new System.Windows.Point(0.5, 0.5);
-            b.Center = new System.Windows.Point(0.5, 0.5);
+            b.GradientOrigin = new Point(0.5, 0.5);
+            b.Center = new Point(0.5, 0.5);
             b.RadiusX = 0.5;
             b.RadiusY = 0.5;
 
             if (this.GradientUnits == SVGTags.sUserSpaceOnUse)
             {
-                b.Center = new System.Windows.Point(this.CX, this.CY);
-                b.GradientOrigin = new System.Windows.Point(this.FX, this.FY);
+                b.Center = new Point(this.CX, this.CY);
+                b.GradientOrigin = new Point(this.FX, this.FY);
                 b.RadiusX = this.R;
                 b.RadiusY = this.R;
                 b.MappingMode = BrushMappingMode.Absolute;
@@ -58,12 +59,12 @@ public override Brush GetBrush(double opacity, SVG svg, SVGRender svgRender, Rec
                 double scale = 1d / 100d;
                 if (double.IsNaN(this.CX) == false && double.IsNaN(this.CY) == false)
                 {
-                    //b.GradientOrigin = new System.Windows.Point(this.CX*scale, this.CY*scale);
-                    b.Center = new System.Windows.Point(this.CX /* *scale */, this.CY /* *scale */);
+                    //b.GradientOrigin = new Point(this.CX*scale, this.CY*scale);
+                    b.Center = new Point(this.CX /* *scale */, this.CY /* *scale */);
                 }
                 if (double.IsNaN(this.FX) == false && double.IsNaN(this.FY) == false)
                 {
-                    b.GradientOrigin = new System.Windows.Point(this.FX * scale, this.FY * scale);
+                    b.GradientOrigin = new Point(this.FX * scale, this.FY * scale);
                 }
                 if (double.IsNaN(this.R) == false)
                 {

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public GradientColorPaintServer(PaintServerManager owner, XmlNode node) : base(o`
`28`	`28`	`{`
`29`	`29`	`string refid = XmlUtil.AttrValue(node, "xlink:href", string.Empty);`
`30`	`30`	`string paintServerKey = owner.Parse(refid.Substring(1));`
`31`		`- GradientColorPaintServer refcol = owner.GetServers()[paintServerKey] as GradientColorPaintServer;`
	`31`	`+ GradientColorPaintServer refcol = owner.GetServer(paintServerKey) as GradientColorPaintServer;`
`32`	`32`	`if (refcol == null) return;`
`33`	`33`	`this.m_stops = new List<GradientStop>(refcol.m_stops);`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`		`-using System.Windows;`
	`1`	`+using System.Xml;`
	`2`	`+`
	`3`	`+using System.Windows;`
`2`	`4`	`using System.Windows.Media;`
`3`		`-using System.Xml;`
`4`	`5`
`5`	`6`	`namespace SVGImage.SVG.PaintServer`
`6`	`7`	`{`
`@@ -28,6 +29,7 @@ public LinearGradientColorPaintServerPaintServer(PaintServerManager owner, Brush`
`28`	`29`	`{`
`29`	`30`	`Brush = newBrush;`
`30`	`31`	`}`
	`32`	`+`
`31`	`33`	`public override Brush GetBrush(double opacity, SVG svg, SVGRender svgRender, Rect bounds)`
`32`	`34`	`{`
`33`	`35`	`if (this.Brush != null) return this.Brush;`
`@@ -36,30 +38,30 @@ public override Brush GetBrush(double opacity, SVG svg, SVGRender svgRender, Rec`
`36`	`38`	`foreach (GradientStop stop in this.Stops) b.GradientStops.Add(stop);`
`37`	`39`
`38`	`40`	`b.MappingMode = BrushMappingMode.RelativeToBoundingBox;`
`39`		`- b.StartPoint = new System.Windows.Point(0, 0);`
`40`		`- b.EndPoint = new System.Windows.Point(1, 0);`
	`41`	`+ b.StartPoint = new Point(0, 0);`
	`42`	`+ b.EndPoint = new Point(1, 0);`
`41`	`43`
`42`	`44`	`if (this.GradientUnits == SVGTags.sUserSpaceOnUse)`
`43`	`45`	`{`
`44`	`46`	`Transform tr = this.Transform as Transform;`
`45`	`47`	`if (tr != null)`
`46`	`48`	`{`
`47`		`- b.StartPoint = tr.Transform(new System.Windows.Point(this.X1, this.Y1));`
`48`		`- b.EndPoint = tr.Transform(new System.Windows.Point(this.X2, this.Y2));`
	`49`	`+ b.StartPoint = tr.Transform(new Point(this.X1, this.Y1));`
	`50`	`+ b.EndPoint = tr.Transform(new Point(this.X2, this.Y2));`
`49`	`51`	`}`
`50`	`52`	`else`
`51`	`53`	`{`
`52`		`- b.StartPoint = new System.Windows.Point(this.X1, this.Y1);`
`53`		`- b.EndPoint = new System.Windows.Point(this.X2, this.Y2);`
	`54`	`+ b.StartPoint = new Point(this.X1, this.Y1);`
	`55`	`+ b.EndPoint = new Point(this.X2, this.Y2);`
`54`	`56`	`}`
`55`	`57`	`this.Transform = null;`
`56`	`58`	`b.MappingMode = BrushMappingMode.Absolute;`
`57`	`59`	`}`
`58`	`60`	`else`
`59`	`61`	`{`
`60`	`62`	`this.Normalize();`
`61`		`- if (double.IsNaN(this.X1) == false) b.StartPoint = new System.Windows.Point(this.X1, this.Y1);`
`62`		`- if (double.IsNaN(this.X2) == false) b.EndPoint = new System.Windows.Point(this.X2, this.Y2);`
	`63`	`+ if (double.IsNaN(this.X1) == false) b.StartPoint = new Point(this.X1, this.Y1);`
	`64`	`+ if (double.IsNaN(this.X2) == false) b.EndPoint = new Point(this.X2, this.Y2);`
`63`	`65`	`}`
`64`	`66`
`65`	`67`	`this.Brush = b;`