forked from juanjqo/dqrobotics-interface-coppeliasim
-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Hi, @juanjqo,
This starts from your self-identified unofficial package. Here is a dynamic list of steps to make this official
- Remove (from this repo) the Matlab version, because this will eventually be on its repo (Done in [PR] Adding DQ_CoppeliaSimInterfaceZMQ and DQ_CoppeliaSimInterfaceZMQ Extended #2)
- Be sure that this is an implementation from the class in [Request] CoppeliaSim abstract class cpp-interface-coppeliasim#1 (Done in [PR] Adding DQ_CoppeliaSimInterfaceZMQ and DQ_CoppeliaSimInterfaceZMQ Extended #2)
- Please be sure it works in Ubuntu 22.04 and forward. Ubuntu 20.04 is not needed because the EOL is April 2025. https://ubuntu.com/about/release-cycle (Done in [PR] Adding DQ_CoppeliaSimInterfaceZMQ and DQ_CoppeliaSimInterfaceZMQ Extended #2)
- Please think of an interface that makes it clear what methods are from the original abstract class (the ones we'll commit to supporting) and the many additional ones that you have enabled by zmq.
For instance, you can create those in a different namespace called experimental.Those methods are nice and very welcome but it's a lot to commit to support officially. (Done in [PR] Adding DQ_CoppeliaSimInterfaceZMQ and DQ_CoppeliaSimInterfaceZMQ Extended #2) - Add the abstract version of CoppeliaSimRobot to https://github.com/dqrobotics/cpp-interface-coppeliasim
- Add the CoppeliaSimRobotZMQ to this repository
- Add the CoppeliaSimRobotZMQExtended (if applicable) to this repository
- Add the constructor with an atomic_bool to break any loops. See below. This is important if there are any loops in the interface, so the external application must be able to break them. If no loops exist (there's no blocking method) then this might not be needed.
- Remove the submodule
cppzmq, it does not seem to be used for this version.
- Make the Debian packages #3
- Update https://github.com/SmartArmStack/smart_arm_stack_ROS2 to support this.
- Add to devel PPA
Metadata
Metadata
Labels
enhancementNew feature or requestNew feature or request