This PR adds the abstract class DQ_CoppeliaSimInterface #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods get_object_handle and get_object_handles to match the C++ version.
1 task
ffasilva
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Hi @juanjqo,
Thank you for the pull request! Most of my comments are cosmetic, but the nomenclatures of the methods for getting and setting joint positions, velocities, and torques might require some discussion.
Kind regards,
Frederico
…posed by Frederico. This includes the use of lowercase style for all arguments in the methods, and keep the same spacing between them.
…_joint_positions to match the style of the other methods.
…o set_joint_target_forces and get_joint_forces to comply the style of the set/get methods related to joint positions, and velocities.
|
Hi @juanjqo, Thank you! I have nothing else to add. Kind regards, |
|
Hi @bvadorno, We finished the review. Shall we approve this PR? Kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dqrobotics/developers,
This PR adds the abstract class
DQ_CoppeliaSimInterface. This class was originally proposed and discussed here, and it is based on the current C++ implementation. This abstract class will enable the implementation of the concrete classDQ_CoppeliaSimInterfaceZMQ, which is under development.UML:
Updated UML:
Kind regards,
Juancho