ColoredLines: Refining Board: Renamed BoardPlus items to ...boardPlus.

Author: Daniel Barclay

src/main/scala/com/us/dsb/explore/algs/coloredlines/manual/game/GameLogicSupport.scala

@@ -30,6 +30,15 @@ object GameLogicSupport {
     }
   }
 
+  //???? probably split into BoardState-level vs. level of BoardState + score
+  case class MoveResult(boardPlus: BoardPlus,
+                        //??? clarify re placing next three balls (re interpreting differently in different contexts
+                        anyRemovals: Boolean)
+  {
+    println(s"??? ${this}")
+    //??? print("")
+  }
+
   /**
    * @param board
    *   expected to be empty //???? maybe refactor something?
@@ -132,15 +141,6 @@ object GameLogicSupport {
     postPlacementResult.copy(boardPlus = postPlacementResult.boardPlus.withOnDeckBalls(List.fill(3)(pickRandomBallKind())))
   }
 
-  //???? rename?  isn't _user_ move result; is ball move/placement/arrival result
-  case class MoveResult(boardPlus: BoardPlus,
-                        //??? clarify re placing next three balls (re interpreting differently in different contexts
-                        anyRemovals: Boolean)
-  {
-    println(s"??? ${this}")
-    //??? print("")
-  }
-
   private[game] def doPass(boardPlus: BoardPlus)(implicit rng: Random): MoveResult =
     placeNextBalls(boardPlus)
 

src/main/scala/com/us/dsb/explore/algs/coloredlines/manual/game/lines/LineDetector.scala

@@ -8,18 +8,19 @@ import com.us.dsb.explore.algs.coloredlines.manual.game.board.{BallKind, BoardPl
 //???? TODO:  reduce repeated passing of board, etc.; maybe make LineDetector a
 // class, to be instantiated for each move; or make local class for passing (but
 // leave external-client interface same
-object LineDetector {
+object LineDetector {  //????? adjust most from using BoardPlus to using just BoardState
 
   private[lines] case class LineAxis(labelArray: String,
                                      rowDelta: Int, // -1 / 0 / 1 (Make refined type?)
                                      colDelta: Int)
 
   private[this] val lineAxes =
     List(
-      LineAxis("→", 0, +1), // →  W -->  E
+      LineAxis("→",  0, +1), // →  W -->  E
       LineAxis("↘", +1, +1), // ↘ NW --> SE
-      LineAxis("↓", +1, 0), // ↓ N  --> S
+      LineAxis("↓", +1,  0), // ↓ N  --> S
       LineAxis("↙", +1, -1)) // ↙ NW --> SW
+
   private[this] val relativeDirectionFactors = List(1, -1) // use type of length 2 (refined List?, Tuple2?, some array?)
 
   private[lines] def haveMatchingBallAt(moveBallColor: BallKind,