From 79323c5882ef23e107026a6c1e15a239d2e03fc7 Mon Sep 17 00:00:00 2001 From: Dan Hughes <2237515+dan-hughes@users.noreply.github.com> Date: Thu, 18 Sep 2025 12:01:03 +0100 Subject: [PATCH 1/5] Move docs to separate task --- build.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/build.yaml b/build.yaml index 33464b7e..d8336599 100644 --- a/build.yaml +++ b/build.yaml @@ -43,12 +43,15 @@ BuildWorkflow: - Build_Module_ModuleBuilder - Build_NestedModules_ModuleBuilder - Create_Changelog_Release_Output + - FixEncoding + + docs: - Generate_Conceptual_Help - Generate_Wiki_Content - - FixEncoding pack: - build + - docs - package_module_nupkg hqrmtest: From 24de1d8ac2cc85e48e12e611d2c6a15923b38c82 Mon Sep 17 00:00:00 2001 From: Dan Hughes <2237515+dan-hughes@users.noreply.github.com> Date: Thu, 18 Sep 2025 12:01:22 +0100 Subject: [PATCH 2/5] Add new 32k db page option --- .../AddsDomain/AddsDomain.schema.psm1 | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/source/DSCResources/AddsDomain/AddsDomain.schema.psm1 b/source/DSCResources/AddsDomain/AddsDomain.schema.psm1 index 90b5baec..bb2f8e4d 100644 --- a/source/DSCResources/AddsDomain/AddsDomain.schema.psm1 +++ b/source/DSCResources/AddsDomain/AddsDomain.schema.psm1 @@ -46,7 +46,11 @@ configuration AddsDomain [Parameter()] [boolean] - $EnablePrivilegedAccessManagement = $false + $EnablePrivilegedAccessManagement = $false, + + [Parameter()] + [boolean] + $Enable32KDatabasePages = $false ) Import-DscResource -ModuleName PSDesiredStateConfiguration @@ -142,6 +146,17 @@ configuration AddsDomain } } + if ( $Enable32KDatabasePages -eq $true ) + { + ADOptionalFeature ADDatabase32KPagesFeature + { + DependsOn = "[ADGroup]EnterpriseAdmins_$DomainName" + ForestFQDN = $DomainFQDN + EnterpriseAdministratorCredential = $DomainAdministrator + FeatureName = 'Database 32k pages feature' + } + } + foreach ($trust in $DomainTrusts) { WaitForAdDomain $trust.Name From 7e2c4b7600430f453df26816ef0be4f43d5fe25b Mon Sep 17 00:00:00 2001 From: Dan Hughes <2237515+dan-hughes@users.noreply.github.com> Date: Thu, 18 Sep 2025 12:01:38 +0100 Subject: [PATCH 3/5] Update test --- tests/Unit/DSCResources/Assets/Config/AddsDomain.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Unit/DSCResources/Assets/Config/AddsDomain.yml b/tests/Unit/DSCResources/Assets/Config/AddsDomain.yml index f516b37b..7250c8c0 100644 --- a/tests/Unit/DSCResources/Assets/Config/AddsDomain.yml +++ b/tests/Unit/DSCResources/Assets/Config/AddsDomain.yml @@ -8,6 +8,7 @@ SysvolPath: C:\WindowsTest\SYSVOL ForestMode: Win2012R2 ForceRebootBefore: true EnablePrivilegedAccessManagement: true +Enable32KDatabasePages: true DomainTrusts: Fqdn: northwindtraders.com Name: northwindtraders From 981ff6c53c8bced18f4e0d5d95bb22c71cb83105 Mon Sep 17 00:00:00 2001 From: Dan Hughes <2237515+dan-hughes@users.noreply.github.com> Date: Thu, 18 Sep 2025 12:19:12 +0100 Subject: [PATCH 4/5] Update changelog --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index dc79ffa7..dd7830c7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Added + +- `AddsDomain`: + - Added `Enable32KDatabasePages` parameter. + ### Changed - DscPullServer: From c5f69580644101a529588cbff6e6c510cbe48a5c Mon Sep 17 00:00:00 2001 From: Dan Hughes <2237515+dan-hughes@users.noreply.github.com> Date: Thu, 18 Sep 2025 12:21:56 +0100 Subject: [PATCH 5/5] Update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index dd7830c7..51cadc3a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - `GPRegistryPolicyDsc` to `1.3.1`. - `SharePointDSC` to `5.6.1`. - `ConfigMgrCBDsc` to `4.0.0`. +- build.yml + - Moved documentation tasks to separate step to speed up local builds. ### Fixed