Multiple 1.4.1 type stub issues
#124
dangotbanned
started this conversation in
General
Replies: 1 comment
-
|
Hey @dangotbanned, thanks for the extensive discovery! I think a single issue / PR is completely fine for this. Expressions are kind of a minefield I guess, typewise. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Downstream in
narwhals, I've got a PR open which is trying to adjust to the new stubs:duckdb>=1.4.1typing & warnings narwhals-dev/narwhals#3189From #96 the issues we have seem to stem from (236713a) and (f5d4e42) after which we get a lot of false negatives on:
ConstantExpressionLambdaExpressionDuckDBPyTypeQuestion
Does anyone have a preference for splitting these into individual issues/PRs?
I think the fixes I have for
ConstantExpression+LambdaExpressionwould be pretty minor.There's 1 or 2 examples for
ConstantExpressionin the test suite already 😉Show
ConstantExpressionDuckDBPyTypemight be a little more involved, since it's an issue withchildren.Also the way I've worked around it in
narwhalsprobably wouldn't be the same thing I'd write in the stubsAnyways, thought I'd ask first before opening lots of issues 😄
Beta Was this translation helpful? Give feedback.
All reactions