Skip to content

Validate URLs before opening in url_opener #21

@dvoraj75

Description

@dvoraj75

Context

url_opener.open_url() passes its argument directly to XDG portal / xdg-open without scheme validation. A malformed PR URL from the API could open arbitrary schemes.

Task

Restrict to https:// (or http:///https://). Reject anything else.

Severity: HIGH
Source: Code review H2

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestsecuritySecurity hardeningv1.5.1Targeted for v1.5.1 release

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions