fix: Promise.all on insert events (#391)

dejan-crocoder · web-flow · commit 602c27818d6e · 2024-02-08T17:53:17.000+01:00
diff --git a/packages/functions/transform/src/merge-request-metrics.ts b/packages/functions/transform/src/merge-request-metrics.ts
@@ -1126,10 +1126,7 @@ async function upsertMergeRequestEvents(
   events.push(metricEvents.startedReview);
 
   await deleteMergeRequestEvents(tx, mergeRequestId);
-  console.log(events.length);
-  if (events.length > 0) {
-    await insertMergeRequestEvents(tx, events).run();
-  }
+  await Promise.all(events.map(ev => insertMergeRequestEvents(tx, [ev]).run()))
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -1126,10 +1126,7 @@ async function upsertMergeRequestEvents(`
`1126`	`1126`	`events.push(metricEvents.startedReview);`
`1127`	`1127`
`1128`	`1128`	`await deleteMergeRequestEvents(tx, mergeRequestId);`
`1129`		`- console.log(events.length);`
`1130`		`- if (events.length > 0) {`
`1131`		`- await insertMergeRequestEvents(tx, events).run();`
`1132`		`- }`
	`1129`	`+ await Promise.all(events.map(ev => insertMergeRequestEvents(tx, [ev]).run()))`
`1133`	`1130`	`}`
`1134`	`1131`
`1135`	`1132`