From 34342d27ed298f8f6b7ffaeeb21ece703e8e6761 Mon Sep 17 00:00:00 2001 From: outslept <135520429+outslept@users.noreply.github.com> Date: Tue, 12 Aug 2025 11:15:04 +0300 Subject: [PATCH 1/2] fix: hide ES modules info from summary --- src/analyze/dependencies.ts | 17 ----------------- src/commands/analyze.ts | 9 --------- 2 files changed, 26 deletions(-) diff --git a/src/analyze/dependencies.ts b/src/analyze/dependencies.ts index 4e0810a..a59b66f 100644 --- a/src/analyze/dependencies.ts +++ b/src/analyze/dependencies.ts @@ -1,5 +1,4 @@ import colors from 'picocolors'; -import {analyzePackageModuleType} from '../compute-type.js'; import type { PackageJsonLike, ReportPluginResult, @@ -176,8 +175,6 @@ export async function runDependencyAnalysis( } }; - let cjsDependencies = 0; - let esmDependencies = 0; const dependencyNodes: DependencyNode[] = []; // Recursively traverse dependencies @@ -200,17 +197,6 @@ export async function runDependencyAnalysis( packagePath }); - // Only count CJS/ESM for non-root packages - if (depth > 0) { - const type = analyzePackageModuleType(depPkg); - if (type === 'cjs') cjsDependencies++; - if (type === 'esm') esmDependencies++; - if (type === 'dual') { - cjsDependencies++; - esmDependencies++; - } - } - // Traverse dependencies const allDeps = {...depPkg.dependencies, ...depPkg.devDependencies}; for (const depName of Object.keys(allDeps)) { @@ -297,9 +283,6 @@ export async function runDependencyAnalysis( // Detect duplicates from the collected dependency nodes const duplicateDependencies = detectDuplicates(dependencyNodes); - stats.dependencyCount.cjs = cjsDependencies; - stats.dependencyCount.esm = esmDependencies; - if (duplicateDependencies.length > 0) { stats.dependencyCount.duplicate = duplicateDependencies.length; diff --git a/src/commands/analyze.ts b/src/commands/analyze.ts index ceb7f03..c94a91a 100644 --- a/src/commands/analyze.ts +++ b/src/commands/analyze.ts @@ -84,11 +84,6 @@ export async function run(ctx: CommandContext) { const totalDeps = stats.dependencyCount.production + stats.dependencyCount.development; - const totalDeepDeps = stats.dependencyCount.cjs + stats.dependencyCount.esm; - const esmPercentage = - totalDeepDeps > 0 - ? Math.floor((stats.dependencyCount.esm / totalDeepDeps) * 100) - : 0; const summaryPairs: Array<[string, string]> = [ ['Package Name', stats.name], ['Version', stats.version], @@ -101,10 +96,6 @@ export async function run(ctx: CommandContext) { [ 'Dependencies', `${totalDeps} (${stats.dependencyCount.production} production, ${stats.dependencyCount.development} development)` - ], - [ - 'ES Modules', - `${esmPercentage}% (${stats.dependencyCount.esm} ESM, ${stats.dependencyCount.cjs} CJS)` ] ]; From 8e9bfd1c24a7791a2f416fe57a1fc445d562cbcc Mon Sep 17 00:00:00 2001 From: outslept <135520429+outslept@users.noreply.github.com> Date: Tue, 12 Aug 2025 11:21:09 +0300 Subject: [PATCH 2/2] chore: revert dependencies file just an inchident --- src/analyze/dependencies.ts | 17 +++++++++++++++++ src/test/__snapshots__/cli.test.ts.snap | 2 -- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/analyze/dependencies.ts b/src/analyze/dependencies.ts index a59b66f..4e0810a 100644 --- a/src/analyze/dependencies.ts +++ b/src/analyze/dependencies.ts @@ -1,4 +1,5 @@ import colors from 'picocolors'; +import {analyzePackageModuleType} from '../compute-type.js'; import type { PackageJsonLike, ReportPluginResult, @@ -175,6 +176,8 @@ export async function runDependencyAnalysis( } }; + let cjsDependencies = 0; + let esmDependencies = 0; const dependencyNodes: DependencyNode[] = []; // Recursively traverse dependencies @@ -197,6 +200,17 @@ export async function runDependencyAnalysis( packagePath }); + // Only count CJS/ESM for non-root packages + if (depth > 0) { + const type = analyzePackageModuleType(depPkg); + if (type === 'cjs') cjsDependencies++; + if (type === 'esm') esmDependencies++; + if (type === 'dual') { + cjsDependencies++; + esmDependencies++; + } + } + // Traverse dependencies const allDeps = {...depPkg.dependencies, ...depPkg.devDependencies}; for (const depName of Object.keys(allDeps)) { @@ -283,6 +297,9 @@ export async function runDependencyAnalysis( // Detect duplicates from the collected dependency nodes const duplicateDependencies = detectDuplicates(dependencyNodes); + stats.dependencyCount.cjs = cjsDependencies; + stats.dependencyCount.esm = esmDependencies; + if (duplicateDependencies.length > 0) { stats.dependencyCount.duplicate = duplicateDependencies.length; diff --git a/src/test/__snapshots__/cli.test.ts.snap b/src/test/__snapshots__/cli.test.ts.snap index 27d303b..1852ad5 100644 --- a/src/test/__snapshots__/cli.test.ts.snap +++ b/src/test/__snapshots__/cli.test.ts.snap @@ -10,7 +10,6 @@ exports[`CLI > should display package report 1`] = ` │ Version 1.0.0 │ Install Size 170.0 B │ Dependencies 1 (1 production, 0 development) -│ ES Modules 0% (0 ESM, 0 CJS) │ ● Results: │ @@ -35,7 +34,6 @@ exports[`CLI > should run successfully with default options 1`] = ` │ Version 1.0.0 │ Install Size 170.0 B │ Dependencies 1 (1 production, 0 development) -│ ES Modules 0% (0 ESM, 0 CJS) │ ● Results: │