bug fixes, ruby version 2.3, rubocop and fasterer applied

Author: eGust

.rubocop.yml

@@ -0,0 +1,20 @@
+AllCops:
+  TargetRubyVersion: 2.3
+
+Metrics/LineLength:
+  Max: 99
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/Documentation:
+  Enabled: false

Gemfile

@@ -1,6 +1,6 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in vue_cli-rails.gemspec
 gemspec

Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "vue_cli/rails"
+require 'bundler/setup'
+require 'vue_cli/rails'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "vue_cli/rails"
 # require "pry"
 # Pry.start
 
-require "pry"
+require 'pry'
 Pry.start(__FILE__)

lib/source/app/controllers/vue_controller.rb

@@ -1,9 +1,7 @@
 class VueController < ApplicationController
   layout 'vue'
 
-  def foo
-  end
+  def foo; end
 
-  def bar
-  end
+  def bar; end
 end

lib/tasks/vue.rake

@@ -4,7 +4,7 @@ namespace :vue do
     pm = VueCli::Rails::NodeEnv.new
     abort('Cannot find node.js') unless pm.node?
 
-    get_input = ->(message, list = 'Yn') {
+    get_input = lambda { |message, list = 'Yn'|
       list = list.chars
       default = list.find { |c| c.upcase == c }
       list = list.map { |c| c == default ? c : c.downcase }.uniq
@@ -15,6 +15,7 @@ namespace :vue do
         r = STDIN.gets.chop.downcase
         break default if r == ''
         break r if list.include?(r)
+
         print "  [INVALID!] Please retry: #{valid}:"
       end
     }
@@ -68,7 +69,7 @@ namespace :vue do
     if src.exist? && src.directory?
       puts 'Detected `src` folder (should be generated by vue-cli)'
       input = get_input.call('  Do you want to delete src folder?')
-      FileUtils.rm_rf src if input == 'y'
+      FileUtils.rm_rf(src.to_s) if input == 'y'
     end
 
     # 5. copy sample codes
@@ -121,13 +122,13 @@ namespace :vue do
   end
 
   desc 'Dump config/vue.yml to_json'
-  task :json_config => :environment do
+  task json_config: :environment do
     config = VueCli::Rails::Configuration.new
     puts config.to_json
   end
 
   desc 'Bundle assets for production'
-  task :compile => :environment do
+  task compile: :environment do
     pm = VueCli::Rails::Configuration.instance.node_env
     pm.exec('vue-cli-service build', env: { 'RAILS_ENV' => 'production' })
   end

lib/vue_cli/rails.rb

@@ -1,4 +1,4 @@
-require "vue_cli/rails/version"
+require 'vue_cli/rails/version'
 require 'vue_cli/rails/configuration'
 require 'vue_cli/rails/node_env'
 

lib/vue_cli/rails/configuration.rb

@@ -25,7 +25,7 @@ def load_config(config)
         resolve_config(config, 'manifestOutput')
 
         cfg_alias = config['alias']
-        cfg_alias.keys.each { |k| resolve_config(cfg_alias, k) }
+        cfg_alias.each_key { |k| resolve_config(cfg_alias, k) }
         dev_server = config['devServer'] || {}
         resolve_config(dev_server, 'contentBase')
 

lib/vue_cli/rails/dev_server_proxy.rb

@@ -12,9 +12,9 @@ def initialize(app)
 
       def perform_request(env)
         if env['PATH_INFO'].start_with?(@assets_path)
-          env["HTTP_HOST"] = env["HTTP_X_FORWARDED_HOST"] = env["HTTP_X_FORWARDED_SERVER"] = @host
-          env["HTTP_X_FORWARDED_PROTO"] = env["HTTP_X_FORWARDED_SCHEME"] = 'http'
-          env["SCRIPT_NAME"] = ''
+          env['HTTP_HOST'] = env['HTTP_X_FORWARDED_HOST'] = env['HTTP_X_FORWARDED_SERVER'] = @host
+          env['HTTP_X_FORWARDED_PROTO'] = env['HTTP_X_FORWARDED_SCHEME'] = 'http'
+          env['SCRIPT_NAME'] = ''
           super(env)
         else
           @app.call(env)

lib/vue_cli/rails/node_env.rb

@@ -18,10 +18,10 @@ def initialize
         end
       end
 
-      def use!(pm)
-        @pm = pm.to_sym
+      def use!(manager)
+        @pm = manager.to_sym
         raise(ArgumentError, "Unsupported manager: #{@pm}") unless %i[npm yarn].include?(@pm)
-        raise(VueCli::Rails::Error, "Not installed: #{@pm}") unless self.try(:"#{@pm}?")
+        raise(VueCli::Rails::Error, "Not installed: #{@pm}") unless try(:"#{@pm}?")
       end
 
       def package_manager
@@ -30,15 +30,15 @@ def package_manager
 
       def exec(command, args = nil, extra = nil, env: {})
         cmd = COMMAND_LINE[command.to_sym] || {}
-        if @pm == :yarn && cmd[:yarn]
-          cmd = cmd[:yarn]
-        elsif @pm == :npm && cmd[:npm]
-          cmd = cmd[:npm]
-        elsif cmd[:npx]
-          cmd = @pm == :yarn ? "yarn exec #{cmd[:npx]}" : "npx #{cmd[:npx]}"
-        else
-          cmd = @pm == :yarn ? "yarn exec #{command}" : "npx #{command}"
-        end
+        cmd = if @pm == :yarn && cmd[:yarn]
+                cmd[:yarn]
+              elsif @pm == :npm && cmd[:npm]
+                cmd[:npm]
+              elsif cmd[:npx]
+                @pm == :yarn ? "yarn exec #{cmd[:npx]}" : "npx #{cmd[:npx]}"
+              else
+                @pm == :yarn ? "yarn exec #{command}" : "npx #{command}"
+              end
 
         cmd = "#{cmd} #{args}" if args.present?
         cmd = "#{cmd} #{@pm == :yarn ? '-- ' : ''}#{extra}" if extra.present?
@@ -53,7 +53,7 @@ def exec(command, args = nil, extra = nil, env: {})
         },
         global_add: {
           yarn: 'yarn global add',
-          npm: 'npm i -g'
+          npm: 'npm i -g',
         },
       }.freeze
 
@@ -66,14 +66,14 @@ def method_missing(cmd, *args)
       def get_version_of(bin)
         return @versions[bin] if @versions.key?(bin)
 
-        r = `#{bin} --version`.strip.presence rescue nil
+        r = begin
+              `#{bin} --version`.strip.presence
+            rescue StandardError
+              nil
+            end
         @versions[bin] = r && r.start_with?('v') ? r[1..-1] : r
         @versions[bin]
       end
-
-      def version_ge?(v1, v2)
-        Gem::Version.new(v1) >= Gem::Version.new(v2)
-      end
     end
   end
 end