Skip to content

[BUG] COMMENT_RPC rule false negative behavior #213

@korchizhinskiy

Description

@korchizhinskiy

I get a false negative behavior with check the COMMENT_RPC rule.
Below I set up a minimal code for to reproduce.

my.proto

package my.v1;

service Greeter {
  // Comment
  rpc SayHello (HelloRequest) returns (HelloResponse) {}
}

message HelloRequest {
  string name = 1;
}

message HelloResponse {
  string name = 1;
}

easyp.yaml

lint:
  use:
    - COMMENT_RPC

To Reproduce
Steps to reproduce the behavior:

  1. Set up a project structure with a file content above.
  2. Run easyp linter by command: easyp lint
  3. Get false negative, which say rpc comment is empty.

Expected behavior
No issue, because rpc is commented, but issue not view, if i comment service, and not comment any rpc in this service.

Desktop (please complete the following information):

  • OS: MacOS
  • CLI Tool version: from brew: easyp version v0.16.1+modified

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions