Skip to content

Issues with renaming in new versions #98

@bagooba

Description

@bagooba

PyLIMA is great for microlensing modeling, but with recent updates there have been a few name changes that haven't been propagated throughout the code causing errors. This is especially evident in the user examples, for instance:

In the examples, the fancy parameters are still defined as
"fancy = pyLIMA_fancy_parameters.standard_fancy_parameters"
but the class name has changed to pyLIMA_fancy_parameters.StandardFancyParameters().
Also, when the telescope.Telescope function is called in the examples, the light_curve arguments should be changed to lightcurve (without the underscore), to match the new parameter name in the source code.

Also, in the models/ML_model.py file, when the fancy_parameters dictionary is not null, the for loops general iterate over
"self.fancy_parameters.fancy_parameters.keys()",
however a subdictionary within fancy_parameters called "fancy_parameters" doesn't exist, so it should probably be just
"self.fancy_parameters.keys()",
unless I'm missing something. Without the change, we get an error of "fancy_parameters not in 'dict'" or something like that, and the modeling doesn't work.

I haven't encountered any others as of yet, but it might be a good idea to just double check where you've changed parameter and class names to ensure that they are consistent throughout the code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions