Skip to content

Commit 59eb82d

Browse files
committed
feat(ci): allow for --no-squash argument
Apparently the Tomcat image can't be squashed
1 parent 44cf792 commit 59eb82d

File tree

2 files changed

+42
-14
lines changed

2 files changed

+42
-14
lines changed

.github/workflows/build-images.yml

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,33 @@ jobs:
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
image: [
20-
'jkube-java', 'jkube-java-17', 'jkube-java-11', 'jkube-jetty9', 'jkube-karaf', 'jkube-remote-dev', 'jkube-tomcat9', 'jkube-tomcat'
21-
]
19+
image:
20+
- name: 'jkube-java'
21+
args: ''
22+
- name: 'jkube-java-17'
23+
args: ''
24+
- name: 'jkube-java-11'
25+
args: ''
26+
- name: 'jkube-jetty9'
27+
args: ''
28+
- name: 'jkube-karaf'
29+
args: ''
30+
- name: 'jkube-remote-dev'
31+
args: ''
32+
- name: 'jkube-tomcat9'
33+
args: ''
34+
- name: 'jkube-tomcat'
35+
args: --no-squash
2236
steps:
2337
- name: Checkout
2438
uses: actions/checkout@v3
2539
- name: Install CEKit
2640
uses: cekit/actions-setup-cekit@v1.1.7
27-
- name: Build ${{ matrix.image }}
41+
- name: Build ${{ matrix.image.name }}
2842
run: |
29-
echo "Building quay.io/jkube/${{ matrix.image }}:${TAG}"
30-
cekit --descriptor ${{ matrix.image }}.yaml build docker --tag="quay.io/jkube/${{ matrix.image }}:${TAG}"
43+
echo "Building quay.io/jkube/${{ matrix.image.name }}:${TAG}"
44+
cekit --descriptor ${{ matrix.image.name }}.yaml build docker ${{ matrix.image.args }} --tag="quay.io/jkube/${{ matrix.image.name }}:${TAG}"
3145
- name: Test
3246
if: success()
3347
run: |
34-
./scripts/test-${{ matrix.image }}.sh
48+
./scripts/test-${{ matrix.image.name }}.sh

.github/workflows/push-images.yml

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,23 @@ jobs:
1212
strategy:
1313
fail-fast: false
1414
matrix:
15-
image: [
16-
'jkube-java', 'jkube-java-17', 'jkube-java-11', 'jkube-jetty9', 'jkube-karaf', 'jkube-remote-dev', 'jkube-tomcat9', 'jkube-tomcat'
17-
]
15+
image:
16+
- name: 'jkube-java'
17+
args: ''
18+
- name: 'jkube-java-17'
19+
args: ''
20+
- name: 'jkube-java-11'
21+
args: ''
22+
- name: 'jkube-jetty9'
23+
args: ''
24+
- name: 'jkube-karaf'
25+
args: ''
26+
- name: 'jkube-remote-dev'
27+
args: ''
28+
- name: 'jkube-tomcat9'
29+
args: ''
30+
- name: 'jkube-tomcat'
31+
args: --no-squash
1832
steps:
1933
- name: Checkout
2034
uses: actions/checkout@v3
@@ -24,12 +38,12 @@ jobs:
2438
id: get_version
2539
run: |
2640
export GITHUB_TAG=${GITHUB_REF/refs\/tags\//}
27-
echo "TAG=quay.io/jkube/${{ matrix.image }}:${GITHUB_TAG/v/}" >> $GITHUB_ENV
28-
- name: Build ${{ matrix.image }}
41+
echo "TAG=quay.io/jkube/${{ matrix.image.name }}:${GITHUB_TAG/v/}" >> $GITHUB_ENV
42+
- name: Build ${{ matrix.image.name }}
2943
run: |
3044
echo "Building ${TAG}"
31-
cekit --descriptor ${{ matrix.image }}.yaml build docker --tag="${TAG}"
32-
- name: Push quay.io/jkube/${{ matrix.image }}
45+
cekit --descriptor ${{ matrix.image.name }}.yaml build docker ${{ matrix.image.args }} --tag="${TAG}"
46+
- name: Push quay.io/jkube/${{ matrix.image.name }}
3347
run: |
3448
echo "Pushing ${TAG}"
3549
docker login -u=${{ secrets.QUAY_USER }} -p=${{ secrets.QUAY_TOKEN }} quay.io

0 commit comments

Comments
 (0)