add typing

Author: kgraeper

.github/workflows/test_integration.yml

@@ -14,7 +14,7 @@
 # Workflow configuration for S-CORE CI - Bazel Build & Test baselibs
 # This workflow runs Bazel build and test when triggered by specific pull request events.
 
-name: Bazel Build some repositories
+name: build latest mains
 on:
   workflow_dispatch:
   push:

integration_test.sh

@@ -103,6 +103,9 @@ echo "" >> "${SUMMARY_FILE}"
 overall_warn_total=0
 overall_depr_total=0
 
+# Track if any build group failed
+any_failed=0
+
 for group in "${!BUILD_TARGET_GROUPS[@]}"; do
     targets="${BUILD_TARGET_GROUPS[$group]}"
     log_file="${LOG_DIR}/${group}.log"
@@ -116,6 +119,10 @@ for group in "${!BUILD_TARGET_GROUPS[@]}"; do
     set +e
     bazel build --config "${CONFIG}" ${targets} --verbose_failures 2>&1 | tee "$log_file"
     build_status=${PIPESTATUS[0]}
+    # Track if any build group failed
+    if [[ ${build_status} -ne 0 ]]; then
+        any_failed=1
+    fi
     set -e
     echo "::endgroup::"  # End Bazel build group
     end_ts=$(date +%s)
@@ -157,4 +164,9 @@ echo "| TOTAL |  |  | ${overall_warn_total} | ${overall_depr_total} |  |" >> "${
 echo '::group::Build Summary'
 echo '=== Build Summary (echo) ==='
 cat "${SUMMARY_FILE}" || echo "(Could not read summary file ${SUMMARY_FILE})"
-echo '::endgroup::'
+echo '::endgroup::'
+
+# Report to GitHub Actions if any build group failed
+if [[ ${any_failed} -eq 1 ]]; then
+    echo "::error::One or more build groups failed. See summary above."
+fi

tools/get_module_info.py

@@ -3,9 +3,10 @@
 
 import json
 import sys
+from typing import Dict, Any
 
 
-def load_module_data(known_good_file, module_name):
+def load_module_data(known_good_file: str, module_name: str) -> Dict[str, Any]:
     """
     Load module data from known_good.json.
     
@@ -25,7 +26,7 @@ def load_module_data(known_good_file, module_name):
         return {}
 
 
-def get_module_field(module_data, field='hash'):
+def get_module_field(module_data: Dict[str, Any], field: str = 'hash') -> str:
     """
     Extract a specific field from module data.
     

tools/update_module_from_known_good.py

@@ -16,9 +16,10 @@
 import re
 from datetime import datetime
 import logging
+from typing import Dict, List, Any, Optional
 
 
-def load_known_good(path):
+def load_known_good(path: str) -> Dict[str, Any]:
     """Load and parse the known_good.json file."""
     with open(path, "r", encoding="utf-8") as f:
         data = json.load(f)
@@ -31,7 +32,7 @@ def load_known_good(path):
     )
 
 
-def generate_git_override_blocks(modules_dict, repo_commit_dict):
+def generate_git_override_blocks(modules_dict: Dict[str, Any], repo_commit_dict: Dict[str, str]) -> List[str]:
     """Generate bazel_dep and git_override blocks for each module."""
     blocks = []
 
@@ -90,7 +91,7 @@ def generate_git_override_blocks(modules_dict, repo_commit_dict):
     return blocks
 
 
-def generate_file_content(modules, repo_commit_dict, timestamp=None):
+def generate_file_content(modules: Dict[str, Any], repo_commit_dict: Dict[str, str], timestamp: Optional[str] = None) -> str:
     """Generate the complete content for score_modules.MODULE.bazel."""
     # License header assembled with parenthesis grouping (no indentation preserved in output).
     header = (
@@ -124,7 +125,7 @@ def generate_file_content(modules, repo_commit_dict, timestamp=None):
     return header + "\n".join(blocks)
 
 
-def main():
+def main() -> None:
     parser = argparse.ArgumentParser(
         description="Generate score_modules.MODULE.bazel from known_good.json"
     )