Skip to content

Revert "Upgrade to python 3.12" #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macdiesel merged 1 commit into from
Nov 5, 2025
Merged

Revert "Upgrade to python 3.12" #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
os:
- ubuntu-latest
python-version:
- 3.12
- 3.11
targets: [ 'quality','main.test','docs' ]

steps:
Expand All @@ -40,7 +40,7 @@ jobs:
&& export TOXENV=django42 && make test.requirements tox.requirements ${{ matrix.targets }}"

- name: Run Coverage
if: matrix.python-version == '3.12' && matrix.targets=='main.test'
if: matrix.python-version == '3.11' && matrix.targets=='main.test'
uses: py-cov-action/python-coverage-comment-action@v3
with:
GITHUB_TOKEN: ${{ github.token }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mysql8-migrations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest ]
python-version: [ 3.12 ]
python-version: [ 3.11 ]

steps:
- name: Checkout repo
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upgrade-python-requirements.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
uses: openedx/.github/.github/workflows/upgrade-python-requirements.yml@master
with:
branch: ${{ github.event.inputs.branch || 'master' }}
python_version: "3.12"
python_version: "3.11"
# optional parameters below; fill in if you'd like github or email notifications
# user_reviewers: ""
# team_reviewers: ""
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ version: 2
build:
os: "ubuntu-lts-latest"
tools:
python: "3.12"
python: "3.11"

# Build documentation in the docs/ directory with Sphinx
sphinx:
Expand Down
6 changes: 3 additions & 3 deletions requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
Expand All @@ -11,9 +11,9 @@ asgiref==3.10.0
# django-countries
boto==2.49.0
# via -r requirements/base.in
boto3==1.40.57
boto3==1.40.56
# via -r requirements/base.in
botocore==1.40.57
botocore==1.40.56
# via
# boto3
# s3transfer
Expand Down
2 changes: 1 addition & 1 deletion requirements/ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
Expand Down
6 changes: 3 additions & 3 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
Expand All @@ -11,9 +11,9 @@ asgiref==3.10.0
# django-countries
boto==2.49.0
# via -r requirements/base.in
boto3==1.40.57
boto3==1.40.56
# via -r requirements/base.in
botocore==1.40.57
botocore==1.40.56
# via
# boto3
# s3transfer
Expand Down
6 changes: 3 additions & 3 deletions requirements/doc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
Expand All @@ -21,9 +21,9 @@ beautifulsoup4==4.14.2
# via pydata-sphinx-theme
boto==2.49.0
# via -r requirements/base.in
boto3==1.40.57
boto3==1.40.56
# via -r requirements/base.in
botocore==1.40.57
botocore==1.40.56
# via
# boto3
# s3transfer
Expand Down
4 changes: 2 additions & 2 deletions requirements/pip.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# pip-compile --allow-unsafe --output-file=requirements/pip.txt requirements/pip.in
# pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --output-file=requirements/pip.txt --pip-args=None requirements/pip.in
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pip-compile command line in the header includes non-standard options (--cert=None, --client-cert=None, --index-url=None, --pip-args=None) that are not present in the Makefile's 'upgrade' target. This suggests the file was not regenerated using the standard 'make upgrade' command. The requirements should be regenerated using 'make upgrade' to ensure consistency with the project's build process.

Suggested change
# pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --output-file=requirements/pip.txt --pip-args=None requirements/pip.in
# pip-compile --allow-unsafe --output-file=requirements/pip.txt requirements/pip.in

Copilot uses AI. Check for mistakes.
#
wheel==0.45.1
# via -r requirements/pip.in
Expand Down
4 changes: 2 additions & 2 deletions requirements/pip_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
# pip-compile --cert=None --client-cert=None --index-url=None --output-file=requirements/pip_tools.txt --pip-args=None requirements/pip_tools.in
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pip-compile command line in the header has been changed from the expected 'make upgrade' (as seen in other requirement files) to an explicit command with unusual options (--cert=None, --client-cert=None, --index-url=None, --pip-args=None). This suggests the file was not regenerated using the standard 'make upgrade' command defined in the Makefile. The requirements should be regenerated using 'make upgrade' to ensure consistency with the project's build process.

Suggested change
# pip-compile --cert=None --client-cert=None --index-url=None --output-file=requirements/pip_tools.txt --pip-args=None requirements/pip_tools.in
# make upgrade

Copilot uses AI. Check for mistakes.
#
build==1.3.0
# via pip-tools
Expand Down
6 changes: 3 additions & 3 deletions requirements/production.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
Expand All @@ -11,9 +11,9 @@ asgiref==3.10.0
# django-countries
boto==2.49.0
# via -r requirements/base.in
boto3==1.40.57
boto3==1.40.56
# via -r requirements/base.in
botocore==1.40.57
botocore==1.40.56
# via
# boto3
# s3transfer
Expand Down
6 changes: 3 additions & 3 deletions requirements/test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
Expand All @@ -13,9 +13,9 @@ astroid==3.3.11
# via pylint
boto==2.49.0
# via -r requirements/base.in
boto3==1.40.57
boto3==1.40.56
# via -r requirements/base.in
botocore==1.40.57
botocore==1.40.56
# via
# boto3
# s3transfer
Expand Down
2 changes: 1 addition & 1 deletion requirements/tox.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
skipsdist = True
envlist = py312-django{42}
envlist = py311-django{42}

[testenv]
passenv =
Expand Down
Loading