Suggestion: change how constructor is called

[ssilverman]

RemoteDisplay/src/RemoteDisplay.h

Line 92 in a163e1a

EthernetUDP udpStream = EthernetUDP(40);

Change suggestion:

EthernetUDP udpStream(40);

This avoids using the copy constructor and instead constructs it in place.

Side question: why a queue size of 40? (I’m curious also if NativeEthernet works fine having no inbound queue.)

[egonbeermat]

It won't compile when I make that change, throws a lot of errors - likely because I have an old version of your library from when I was testing your initial modifications to support TLS. Not sure if that ever made it to release?

It's also an outbound queue, not inbound, for streaming packets containing screen updates. It can push over 9 MBytes/s when my Teensy is playing 768x420 video at 24fps. It's been a while so I can't recall why 40, but it's not something I'd do arbitrarily. Saying that, just ran a quick test with it set lower (10) and it is fine pumping out close to 9 MBytes/s so I can lower it.

It's been even longer since I used NativeEthernet, but aren't the buffers/queues defined differently (macros, etc) in that lib?