Filter feature not working?

[ZaphodJustSomeGuy]

I believe the filter feature is to either exclusively use the named WSs or remove them from being used (it isn't clear in the docs which way round the filter works). However I can't test it either way as the command never seems to add the WS to the list.

So given a test example, using corsair with a Tauret dagger in main hand.
When I type:
//asc filter Evisceration

I get the response: autoSC: WS Evisceration added to the filtered WSs for Tauret

But it doesn't show in the filtered section of the on-screen widget, that just stays blank.

If I look at the <charname.xml> settings file which does get updated instantly at that time, the entries just show either a blank line or a single unpopulated entry, for instance:

        <ws_filters>
            <carnwenhan>

            </carnwenhan>
            <naegling>

            </naegling>
            <tauret />
        </ws_filters>

Is this me doing something wrong or perhaps something has changed in the few years since it was last tested that has broken the filter feature? btw I don't enter the WS name with auto-translation or anything like that (as I know then it doesn't accept the command anyway).

Cheers in advance

[ekrividus]

Hmm. That is newly broken for sure. I know there were some WS names that caused fits in the past and I can't remember if I fixed things for those or not, but Evisceration shouldn't cause issues.

Filtered WSs are ignored by the addon. Handy for when you're trying to make a specific SC but there's 2 closers of the same level. Also perhaps more handy for setting up silly things like multi-step Aeolian Edge or the like or stopping Fell Cleave from stepping on your SCs and pulling a room of non-aggro mobs during XP parties.

Assuming that you copy/pasted that directly from the settings could you change the <tauret /> to

<tauret>
    Evisceration
</tauret>

Just for the sake of testing. This should stop it using Evisceration ever with this weapon. Once you've added that see if you can add/remove other WSs. Hopefully this was a one off and that'll fix it.

I'll also update the documentation to better relate what the filter is for.

[ZaphodJustSomeGuy]

Hi, I finally got around to trying this.

Once I figured out the syntax I put in:

    <ws_filters>
        <heishi_shorinken>
            <1>Blade: Retsu</1>
            <2>Blade: Yu</2>
            <3>Blade: Kamu</3>
            <4>Blade: Jin</4>
            <5>Blade: Ei</5>
            <6>Blade: Shun</6>
            <7>Blade: To</7>
        </heishi_shorinken>
    </ws_filters>

This would show the filtered WS ok in the widget, so I think this works for adding the filter where the command doesn't work (it seems the command doesn't ever add the weapon name section).

Even though I wanted to get the result of Blade: Chi and Blade: Teki alternating (since they will chain over and over), it would never follow Chi with Teki, just kept opening with Chi.

Hoping you might make it back to the game, I do get a lot of use out of your addon even with the issues.

[ekrividus]

I'll still have a look at the code to see if I can't sort out why it isn't adding/removing things properly. Assuming you don't mind a bit of testing when I make changes.

What if you turn off opening chains (just to test) and start the Teki <> Chi loop and see if it'll continue it forever? I seem to recall having issues with this on Sam too. It took some fiddling to get it to 6 step effectively. Same with Aeolian Edge. I'm gonna have a look at my settings to see if there's any hints.

So lets double check your close_levels 1=true, maybe disable 2~4.
min_ws_window = 3
max_ws_window = 7
wait_to_open = true
target_sc_level = 1

Some of those are a bit redundant just to force the level 1 SCs for testing. It's also possible that a SC effect is missing from one (or both) WSs in the skills.lua. I know some of those have been adjusted over the years and depending on weapon used they can change which is not accounted for, also why there's no L5 SCs featured. Those were in the TODO but never got TODONE.

[ZaphodJustSomeGuy]

Hi ekrividus

Yep no problem, I've been able to do the test you suggested, I had tried all of that except for manually starting the first Chi. Once I did that, asc would continue down the chain (only +teki and +chi and then the mob is dead since I have a geo). However it wouldn't keep the chain going always and I'd be left with my nin just meleeing the mob and not starting a new chain (this might be because something else happened such as berserk or warcry which pushed asc out of the SC window).

I currently have EF doing the 4 step just using the HP of the mob to decide which to do and that works surprisingly well as I can use a large HP range for each.

Going back to your test, as soon as I told asc to open with chi it seemed to just keep doing chi as an opener and never gets to teki.

[ekrividus]

Ok so that narrows it down some at least. We know that it is willing to chain with just the desired skills, but for some reason opening is getting preference over SCing. That's not ideal behavior but with a couple more tweaks maybe we can get rid of that too.

It could be that EF is stepping on things. Idk how deep EF gets into packets, have you tried Scripted? I mean either way if a JA or w/e fires at the same time ASC is trying to fire a WS that WS will fail and ASC may get janked by that. AMB is the same if/when it gets interrupted. Neither of them should stay jank beyond that 1 firing though. They "should" just fall back to waiting to see a SC effect in a packet and start back normally. Which clearly isn't happening here.

I made a few changes to the code to help with debugging. I think I realize where the issue exists but am not 100% certain so if you can snag the latest and turn on debug messages //asc debug and try a mob or 2 with just asc working. I know testing sux lol.

Adjust:
min_ws_window = 2 You can try lower but you may see it fire faster than the window actually opens depending on your latency and stuff
max_ws_window = 8 I don't remember how long a 6-step window gets anymore but I know it isn't long from open to close so 8 may be too long
attempt_delay = 5 or 0.2 maybe try some with each

Maybe I should try to catch the next freebie campaign and see if the joy has returned yet ...