Skip to content

Commit 96c739d

Browse files
committed
[CI] Test Runner: Use better version comparision for skip_version
1 parent 8f0f3b1 commit 96c739d

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

api-spec-testing/test_file.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,15 @@ def skip_version?(client, skip_definition)
8080
rescue
8181
warn('Could not determine Elasticsearch version when checking if test should be skipped.')
8282
end
83-
range.cover?(server_version)
83+
range.cover?(Gem::Version.new(server_version))
8484
end
8585

8686
def __parse_versions(versions)
8787
versions = versions.split('-') if versions.is_a? String
8888

8989
low = (['', nil].include? versions[0]) ? '0' : versions[0]
9090
high = (['', nil].include? versions[2]) ? '9999' : versions[2]
91-
92-
[low, high]
91+
[Gem::Version.new(low), Gem::Version.new(high)]
9392
end
9493

9594
# Get a list of tests in the test file.

0 commit comments

Comments
 (0)