The current logstash diagnostic creation is not version aware. At
|
RestEntryConfig builder = new RestEntryConfig("1.0.0"); |
we define the version to be
1.0.0.
That is the reason why one of the recent additions (#772) is actually collecting nothing.
Furthermore, the Logstash APIs have only been introduced in 5.0.0, so all the checks for 0.0.0 in https://github.com/elastic/support-diagnostics/blob/main/src/main/resources/logstash-rest.yml won't have an effect if run against Logstash <5.0.0. (See https://www.elastic.co/guide/en/logstash/5.0/monitoring.html).
I believe we would need a version check for Logstash as well, similar as we have for ES and Kibana (eg. https://github.com/elastic/support-diagnostics/blob/main/src/main/java/co/elastic/support/diagnostics/commands/CheckElasticsearchVersion.java)
We would also need to decide what to do with the version check itself for older Logstash versions, as if we implement the version check against the API that will fail.
CC: @lucabelluccini
The current logstash diagnostic creation is not version aware. At
support-diagnostics/src/main/java/co/elastic/support/diagnostics/commands/RunLogstashQueries.java
Line 45 in a5794b1
1.0.0.That is the reason why one of the recent additions (#772) is actually collecting nothing.
Furthermore, the Logstash APIs have only been introduced in
5.0.0, so all the checks for0.0.0in https://github.com/elastic/support-diagnostics/blob/main/src/main/resources/logstash-rest.yml won't have an effect if run against Logstash <5.0.0. (See https://www.elastic.co/guide/en/logstash/5.0/monitoring.html).I believe we would need a version check for Logstash as well, similar as we have for ES and Kibana (eg. https://github.com/elastic/support-diagnostics/blob/main/src/main/java/co/elastic/support/diagnostics/commands/CheckElasticsearchVersion.java)
We would also need to decide what to do with the version check itself for older Logstash versions, as if we implement the version check against the API that will fail.
CC: @lucabelluccini