Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

Initialization #7

@vpopiol

Description

@vpopiol

Hello,

I love this Gem. The only issue I have is that I can't initialize the configuration in a Rails app because of the way you are storing the config in a Thread.current. I had to monkey patch it to store the config in a global variable. Otherwise, I would have to configure it before each call.

This is how I would change the config method in geonames.rb:

def config
  $config ||= Geonames::Config.new
end

Any thoughts?

Thanks for such a cool Gem!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions