Skip to content

Insert brackets after function #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremypw wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Insert brackets after function #292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69ef2af
Insert brackets after function
jeremypw Aug 18, 2025
4274e5a
Fix position
jeremypw Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,18 +573,23 @@ public class PantheonCalculator.MainWindow : Gtk.ApplicationWindow {
var token = variant.get_string ();
int selection_start = -1;
int selection_end = -1;
var selected_text = "";
int new_position = entry.get_position ();
if (entry.get_selection_bounds (out selection_start, out selection_end)) {
int new_position = selection_start;
string selected_text = entry.get_chars (selection_start, selection_end);
string function_call = token + "(" + selected_text + ")";
entry.delete_text (selection_start, selection_end);
entry.insert_text (function_call, -1, ref selection_start);
new_position += function_call.char_count ();
entry.grab_focus ();
entry.set_position (new_position);
} else {
activate_action (ACTION_INSERT, variant);
new_position = selection_start;
selected_text = entry.get_chars (selection_start, selection_end);
}

string function_call = token + "(" + selected_text + ")";
entry.delete_text (selection_start, selection_end);
entry.insert_text (function_call, -1, ref selection_start);
new_position += function_call.char_count ();
entry.grab_focus ();
if (selected_text == "") {
new_position--;
}

entry.set_position (new_position);
}

private void button_calc_clicked () {
Expand Down