Use libpci to retrieve some basic PCI data #440
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
@wpkelso Intel fix just landed in the code. However, I don't see nvidia gpu in the logs 🤔 |
This comment was marked as resolved.
This comment was marked as resolved.
|
Please, if possible, run again and paste the logs. Thank you. |
|
@stsdc This is in an X session: Logs
|
|
Looks like that got it working 🎉. Is it supposed to show graphs for the integrated GPU as well, or only the discrete ones?
|
|
Haha, why it shows AMD on GeForce. Yeah, for Intel also no support so far. |
| set_pci_properties (pci_access, pci_device); | ||
| name = "AMD® " + name; |
There was a problem hiding this comment.
Pesonaly I think this code would be a little bit difficult to read. It looks like as if name is not initialized and thus it results to be just AMD@ without reading into set_pci_properties ().
There was a problem hiding this comment.
Not sure what to do with it. I'm using this Interface a bit like an abstract class.
Feels like the set_pci_properties content should be in the class constructor. But how to make it according to DRY? 🤔
| gpu_view = new SystemGPUView (resources.gpu); | ||
| wrapper.add (gpu_view); | ||
| foreach (var gpu in resources.gpu_list) { | ||
| if (gpu.name.contains ("Intel") || gpu.name.contains ("nVidia")) { |
There was a problem hiding this comment.
This works though, what about using typeof?
There was a problem hiding this comment.
How would You do this?
I have tried if (gpu.get_type () is GPUIntel || gpu.get_type () is GPUNvidia), but got type check expressions not supported for compact classes, structs, and enums
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
This is an attempt at porting libpci to vapi and use it in Monitor to detect PCI devices.
Trying to make a basic example to work.