`Version.InvalidVersionError` due to version with prerelease with leading `0` (zero)

[zoldar]

Unfortunately, the problem originally reported in #35 still persists for exact same example UA string:

UAInspector.parse("Mozilla/5.0 (Linux; arm_64; Android 10; Mi Note 10) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.5765.05 Mobile Safari/537.36"

I have done some digging - my findings follow below:

Although there is a regression test added at

ua_inspector/test/ua_inspector/parser/client_test.exs

Lines 39 to 54 in 8954721

	test "engine version with leading zero in fourth place (x.y.z.0[0-9]+)" do
	agent =
	"Mozilla/5.0 (Linux; arm_64; Android 10; Mi Note 10) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.5765.05 Mobile Safari/537.36"
	parsed = UAInspector.parse(agent)
	result = %UAInspector.Result.Client{
	engine: "WebKit",
	engine_version: "537.36",
	name: "Chrome Mobile",
	type: "browser",
	version: "115.0.5765.05"
	}
	assert ^result = parsed.client
	end

, it does not really test for problematic version comparison. That's because the default database fixture used in tests does not have a matching "WebKit" entry with "versions", so the code path resolving and comparing versions at

ua_inspector/lib/ua_inspector/parser/client.ex

Line 304 in 8954721

if :lt != Util.Version.compare(version, engine_version) do

is not even triggered and default is used.

The root problem here seems to be the fact that after semver conversion for comparison, the version string ends up like this:

UAInspector.Util.Version.to_semver("115.0.5765.05", 4)
"115.0.5765-05"

which in turn causes

ua_inspector/lib/ua_inspector/util/version.ex

Line 29 in 8954721

Version.compare(semver1, semver2)

to fail because leading "0" in prerelease is treated as invalid (which is correct according to https://semver.org/ AFAICT, so it seems to make sense that Version follows that spec). Unfortunately, apparently versions in UA do not always follow the conventions.

Perhaps it would make sense to sanitize the prerelease by trimming any leading zeroes somewhere close to

ua_inspector/lib/ua_inspector/util/version.ex

Lines 157 to 161 in 8954721

	if String.contains?(semver, "-") do
	semver
	else
	semver <> "-0"
	end

? It would have to account for a case where prelease consists entirely of "0", where it should be left intact AFAIU.

[makmn1]

I just tested this and it looks like the issue was fixed in a previous commit:

iex(1)> UAInspector.parse("Mozilla/5.0 (Linux; arm_64; Android 10; Mi Note 10) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.5765.05 Mobile Safari/537.36")                                                                   
%UAInspector.Result{
  user_agent: "Mozilla/5.0 (Linux; arm_64; Android 10; Mi Note 10) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.5765.05 Mobile Safari/537.36",
  browser_family: "Chrome",
  client: %UAInspector.Result.Client{
    engine: "Blink",
    engine_version: "115.0.5765.05",
    name: "Chrome Mobile",
    type: "browser",
    version: "115.0.5765.05"
  },
  device: %UAInspector.Result.Device{
    brand: "Xiaomi",
    model: "Mi Note 10",
    type: "phablet"
  },
  os: %UAInspector.Result.OS{name: "Android", platform: "ARM", version: "10"},
  os_family: "Android"
}

It looks like the file got a revamp about a year ago