Skip to content

Improve message serialization #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gBillal merged 1 commit into from
Jan 10, 2026
Merged

Improve message serialization #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/ex_rtmp/message.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ defmodule ExRTMP.Message do
* `:chunk_size` - The size of each chunk (default: 128)
* `:chunk_stream_id` - The chunk stream id to use (default: 2)
"""
@spec serialize(t(), keyword()) :: iodata()
@spec serialize(t(), keyword()) :: binary()
def serialize(message, opts \\ []) do
chunk_size = Keyword.get(opts, :chunk_size, 128)
chunk_stream_id = Keyword.get(opts, :chunk_stream_id, 2)
Expand All @@ -166,14 +166,20 @@ defmodule ExRTMP.Message do
}

2..entries//1
|> Stream.map(fn idx ->
|> Enum.map(fn idx ->
offset = (idx - 1) * chunk_size
size = min(byte_size(payload) - offset, chunk_size)
binary_part(payload, offset, size)
end)
|> Stream.map(&%Chunk{payload: &1, stream_id: chunk_stream_id, fmt: 3})
|> Enum.map(&Chunk.serialize/1)
|> then(&[Chunk.serialize(first_chunk) | &1])
|> chunks_to_binary(chunk_stream_id, Chunk.serialize(first_chunk))
end

defp chunks_to_binary([], _chunk_stream_id, acc), do: acc

# we always use stream id smaller than 63 since we only allow
# one stream per client/session
defp chunks_to_binary([chunk | rest], stream_id, acc) do
chunks_to_binary(rest, stream_id, <<acc::binary, 3::2, stream_id::6, chunk::binary>>)
end

defp parse_payload(%__MODULE__{type: 1, payload: payload} = msg) do
Expand Down