Skip to content

Commit ae4acfa

Browse files
committed
Use @babel/eslint-parser, fix linting
1 parent 470930f commit ae4acfa

File tree

5 files changed

+17
-4
lines changed

5 files changed

+17
-4
lines changed

packages/ember-bootstrap-constraint-validations/.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
module.exports = {
44
root: true,
5-
parser: 'babel-eslint',
5+
parser: '@babel/eslint-parser',
66
parserOptions: {
77
ecmaVersion: 'latest',
88
sourceType: 'module',

packages/ember-bootstrap-constraint-validations/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@
2929
},
3030
"devDependencies": {
3131
"@babel/core": "^7.17.0",
32+
"@babel/eslint-parser": "^7.18.2",
3233
"@babel/plugin-proposal-class-properties": "^7.16.7",
3334
"@babel/plugin-proposal-decorators": "^7.17.0",
3435
"@babel/plugin-syntax-decorators": "^7.17.0",
3536
"@embroider/addon-dev": "^1.0.0",
3637
"@rollup/plugin-babel": "^5.3.0",
37-
"babel-eslint": "^10.1.0",
3838
"ember-template-lint": "^4.0.0",
3939
"eslint": "^7.32.0",
4040
"eslint-config-prettier": "^8.3.0",

packages/ember-bootstrap-constraint-validations/src/components/bs-form.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@ export default class BsForm extends BaseBsForm {
99
}
1010

1111
async validate(model, form) {
12-
assert('Expected to receive the form element when validating.', form instanceof HTMLFormElement);
12+
assert(
13+
'Expected to receive the form element when validating.',
14+
form instanceof HTMLFormElement
15+
);
1316

1417
if (!form.checkValidity()) {
1518
throw new Error();

packages/ember-bootstrap-constraint-validations/src/components/bs-form/element.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export default class BsFormElement extends BaseBsFormElement {
2020
get errors() {
2121
// native validation state doesn't integrate with Ember's autotracking, so we need to invalidate our `errors` getter explicitly when
2222
// `this.value` changes by consuming it here.
23+
// eslint-disable-next-line no-unused-vars
2324
let { controlElement, value } = this;
2425
return !controlElement || controlElement.validity.valid
2526
? []

yarn.lock

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,15 @@
5050
json5 "^2.2.1"
5151
semver "^6.3.0"
5252

53+
"@babel/eslint-parser@^7.18.2":
54+
version "7.18.2"
55+
resolved "https://registry.yarnpkg.com/@babel/eslint-parser/-/eslint-parser-7.18.2.tgz#e14dee36c010edfb0153cf900c2b0815e82e3245"
56+
integrity sha512-oFQYkE8SuH14+uR51JVAmdqwKYXGRjEXx7s+WiagVjqQ+HPE+nnwyF2qlVG8evUsUHmPcA+6YXMEDbIhEyQc5A==
57+
dependencies:
58+
eslint-scope "^5.1.1"
59+
eslint-visitor-keys "^2.1.0"
60+
semver "^6.3.0"
61+
5362
"@babel/generator@^7.18.0":
5463
version "7.18.0"
5564
resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.18.0.tgz#46d28e8a18fc737b028efb25ab105d74473af43f"
@@ -6009,7 +6018,7 @@ eslint-visitor-keys@^1.0.0, eslint-visitor-keys@^1.1.0, eslint-visitor-keys@^1.3
60096018
resolved "https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-1.3.0.tgz#30ebd1ef7c2fdff01c3a4f151044af25fab0523e"
60106019
integrity sha512-6J72N8UNa462wa/KFODt/PJ3IU60SDpC3QXC1Hjc1BXXpfL2C9R5+AU7jhe0F6GREqVMh4Juu+NY7xn+6dipUQ==
60116020

6012-
eslint-visitor-keys@^2.0.0:
6021+
eslint-visitor-keys@^2.0.0, eslint-visitor-keys@^2.1.0:
60136022
version "2.1.0"
60146023
resolved "https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-2.1.0.tgz#f65328259305927392c938ed44eb0a5c9b2bd303"
60156024
integrity sha512-0rSmRBzXgDzIsD6mGdJgevzgezI534Cer5L/vyMX0kHzT/jiB43jRhd9YUlMGYLQy2zprNmoT8qasCGtY+QaKw==

0 commit comments

Comments
 (0)