Skip to content

Commit 116f79a

Browse files
alexlafrosciasamselikoff
authored andcommitted
Clean up logo code (#127)
* Unify `addonLogo` implementation * Make `logo` setting API of docs-header more consistent * Switch `addonName` to `name` This also updates the implementation to match the documentation
1 parent ebbc50d commit 116f79a

File tree

4 files changed

+25
-30
lines changed

4 files changed

+25
-30
lines changed

addon/components/docs-header/component.js

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import layout from './template';
33
import config from 'dummy/config/environment';
44
import { computed } from '@ember/object';
55
import { classify } from '@ember/string';
6+
import { addonLogo } from 'ember-cli-addon-docs/utils/computed';
67

78
const packageJson = config['ember-cli-addon-docs'].packageJson;
89

@@ -32,22 +33,9 @@ export default Component.extend({
3233

3334
packageJson: packageJson,
3435

35-
addonLogo: computed(function() {
36-
let name = packageJson.name;
37-
let logo;
38-
39-
if (name.match('ember-cli-')) {
40-
logo = 'ember-cli';
41-
} else if (name.match('ember-data-')) {
42-
logo = 'ember-data';
43-
} else if (name.match('ember-data-')) {
44-
logo = 'ember';
45-
}
46-
47-
return logo;
48-
}),
36+
logo: addonLogo(packageJson),
4937

50-
addonName: computed(function() {
38+
name: computed(function() {
5139
let name = packageJson.name;
5240
name = name.replace('ember-data-', '');
5341
name = name.replace('ember-cli-', '');

addon/components/docs-header/template.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
<div class="text-center text-xs">
55
{{#if logo}}
66
<div class='h-4 pb-1'>
7-
{{docs-logo logo=addonLogo}}
7+
{{docs-logo logo=logo}}
88
</div>
99
{{/if}}
10-
<span class='font-medium normal-case block -mt-2px'>{{addonName}}</span>
10+
<span class='font-medium normal-case block -mt-2px'>{{name}}</span>
1111
</div>
1212
{{/docs-header/link}}
1313

addon/components/docs-viewer/x-nav/component.js

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import Component from '@ember/component';
44
import layout from './template';
55
import config from 'dummy/config/environment';
66
import { classify } from '@ember/string';
7+
import { addonLogo } from 'ember-cli-addon-docs/utils/computed';
78

89
const packageJson = config['ember-cli-addon-docs'].packageJson;
910

@@ -17,19 +18,7 @@ export default Component.extend({
1718
store: service(),
1819
packageJson,
1920

20-
addonLogo: computed(function() {
21-
let name = packageJson.name;
22-
let logo;
23-
if (name.match(/ember-cli/)) {
24-
logo = 'ember-cli';
25-
} else if (name.match(/ember-data/)) {
26-
logo = 'ember-data';
27-
} else {
28-
logo = 'ember';
29-
}
30-
31-
return logo;
32-
}),
21+
addonLogo: addonLogo(packageJson),
3322

3423
addonTitle: computed('addonLogo', function() {
3524
let logo = this.get('addonLogo');

addon/utils/computed.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,3 +111,21 @@ export function hasMemberType(...memberKeys) {
111111
});
112112
}
113113

114+
/**
115+
@hide
116+
*/
117+
export function addonLogo(packageJson) {
118+
return computed(function() {
119+
let name = packageJson.name;
120+
let logo;
121+
if (name.match(/ember-cli/)) {
122+
logo = 'ember-cli';
123+
} else if (name.match(/ember-data/)) {
124+
logo = 'ember-data';
125+
} else {
126+
logo = 'ember';
127+
}
128+
129+
return logo;
130+
});
131+
}

0 commit comments

Comments
 (0)