Skip to content

Commit ddc190b

Browse files
yeputonskripken
authored andcommitted
Fix 9069: run_process should not always set universal_newlines parameter to True (#9070)
This fixes #9069 , which allows fixing #9057 in an easier way.
1 parent 92a971b commit ddc190b

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,4 +419,5 @@ a license to everyone to use it as detailed in LICENSE.)
419419
* Christian Clauss <cclauss@me.com> (copyright owned by IBM)
420420
* Henry Kleynhans <hkleynhans@bloomberg.net> (copyright owned by Bloomberg L.P.)
421421
* FUJI Goro <g.psy.va@gmail.com>
422+
* Egor Suvorov <esuvorov@think-cell.com> (copyright owned by think-cell Software GmbH)
422423
* James Kuszmaul <jabukuszmaul@gmail.com>

tools/shared.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def check_returncode(self):
161161
raise Py2CalledProcessError(returncode=self.returncode, cmd=self.args, output=self.stdout, stderr=self.stderr)
162162

163163

164-
def run_process(cmd, check=True, input=None, universal_newlines=True, *args, **kw):
164+
def run_process(cmd, check=True, input=None, *args, **kw):
165165
kw.setdefault('universal_newlines', True)
166166

167167
debug_text = '%sexecuted %s' % ('successfully ' if check else '', ' '.join(cmd))

0 commit comments

Comments
 (0)