Facet constraint processor

Author: zix2

src/Processors/FacetConstraintProcessor.php

@@ -2,54 +2,28 @@
 
 namespace Ensi\LaravelElasticQuerySpecification\Processors;
 
-use Ensi\LaravelElasticQuery\Contracts\BoolQuery;
 use Ensi\LaravelElasticQuerySpecification\Faceting\AllowedFacet;
 use Ensi\LaravelElasticQuerySpecification\Filtering\AllowedFilter;
 use Ensi\LaravelElasticQuerySpecification\Specification\Specification;
-use Ensi\LaravelElasticQuerySpecification\Specification\Visitor;
 
-class FacetConstraintProcessor implements Visitor
+class FacetConstraintProcessor extends ConstraintProcessor
 {
-    public function __construct(private BoolQuery $query)
-    {
-    }
-
     public function visitRoot(Specification $specification): void
     {
         $filters = $specification->facets()
             ->filter(fn (AllowedFacet $facet) => $facet->isActive())
             ->flatMap(fn (AllowedFacet $facet) => $facet->filters())
             ->each(fn (AllowedFilter $filter) => $filter->disable());
 
-        $this->buildConstraints($this->query, $specification);
+        parent::visitRoot($specification);
 
         $filters->each(fn (AllowedFilter $filter) => $filter->enable());
     }
 
     public function visitNested(string $field, Specification $specification): void
     {
-        if ($specification->hasActiveFacet()) {
-            return;
-        }
-
-        if (!$specification->hasActiveFilter()) {
-            return;
-        }
-
-        $this->query->whereHas(
-            $field,
-            fn (BoolQuery $query) => $this->buildConstraints($query, $specification)
-        );
-    }
-
-    public function done(): void
-    {
-    }
-
-    private function buildConstraints(BoolQuery $query, Specification $specification): void
-    {
-        foreach ($specification->constraints() as $constraint) {
-            $constraint($query);
+        if (!$specification->hasActiveFacet()) {
+            parent::visitNested($field, $specification);
         }
     }
 }

tests/Unit/Processors/FacetConstraintProcessorTest.php

@@ -9,19 +9,6 @@
 
 uses()->group('unit');
 
-test('visit root', function () {
-    $spec = Specification::new()->where('foo', 10);
-
-    $query = Mockery::mock(BoolQuery::class);
-    $query->expects('where')
-        ->with('foo', 10)
-        ->once()
-        ->andReturnSelf();
-
-    FluentProcessor::new(FacetConstraintProcessor::class, $query)
-        ->visitRoot($spec);
-});
-
 test('skip active facet filters in root specification', function () {
     $filter = AllowedFilter::exact('foo')->setValue(10);
     $facet = AllowedFacet::minmax('foo');
@@ -60,21 +47,6 @@
         ->visitRoot($spec);
 });
 
-test('nested constraint', function () {
-    $spec = Specification::new()->allowedFilters([
-        AllowedFilter::exact('foo')->default(10),
-    ]);
-
-    $query = Mockery::mock(BoolQuery::class);
-    $query->expects('whereHas')
-        ->with('nested', any())
-        ->once()
-        ->andReturnSelf();
-
-    FluentProcessor::new(FacetConstraintProcessor::class, $query)
-        ->visitNested('nested', $spec);
-});
-
 test('nested specification has active facet', function () {
     $facet = AllowedFacet::minmax('foo');
     $facet->enable();
@@ -87,13 +59,3 @@
     FluentProcessor::new(FacetConstraintProcessor::class, $query)
         ->visitNested('nested', $spec);
 });
-
-test('nested specification does not contain active filters', function () {
-    $spec = Specification::new()->where('foo', 10);
-
-    $query = Mockery::mock(BoolQuery::class);
-    $query->expects('whereHas')->andReturnSelf()->never();
-
-    FluentProcessor::new(FacetConstraintProcessor::class, $query)
-        ->visitNested('nested', $spec);
-});