From 42a18a785e686b5136f2c6f6f919177bed6df4d6 Mon Sep 17 00:00:00 2001 From: Henrik Knutsen <46495473+hknutsen@users.noreply.github.com> Date: Fri, 10 Oct 2025 08:50:23 +0200 Subject: [PATCH 1/5] wip(super-linter): explicitly enable linters --- .github/workflows/super-linter.yml | 56 ++++++++++++++++++++++-------- 1 file changed, 42 insertions(+), 14 deletions(-) diff --git a/.github/workflows/super-linter.yml b/.github/workflows/super-linter.yml index 7de88e79..887df8f3 100644 --- a/.github/workflows/super-linter.yml +++ b/.github/workflows/super-linter.yml @@ -41,23 +41,51 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} FILTER_REGEX_EXCLUDE: ${{ inputs.filter_regex_exclude }} FILTER_REGEX_INCLUDE: ${{ inputs.filter_regex_include }} + + # Don't create status checks per linter. + # Create GitHub Actions job summary instead. + MULTI_STATUS: false + ENABLE_GITHUB_ACTIONS_STEP_SUMMARY: true + # If triggered by PR, only validate changed files. VALIDATE_ALL_CODEBASE: ${{ github.event_name != 'pull_request' }} - # Checkov and JSCPD ignore the above FILTER_REGEX_EXCLUDE, FILTER_REGEX_INCLUDE and VALIDATE_ALL_CODEBASE environment variables. - # Explicitly disable these linters to prevent them from being run when they should not. - VALIDATE_CHECKOV: false - VALIDATE_JSCPD: false + + VALIDATE_CSHARP: true + VALIDATE_DOTNET_SLN_FORMAT_ANALYZERS: true + VALIDATE_DOTNET_SLN_FORMAT_STYLE: true + VALIDATE_DOTNET_SLN_FORMAT_WHITESPACE: true + + VALIDATE_HTML: true + + VALIDATE_CSS: true + + VALIDATE_JAVASCRIPT_ES: true + VALIDATE_JAVASCRIPT_PRETTIER: true + VALIDATE_TYPESCRIPT_ES: true + VALIDATE_TYPESCRIPT_PRETTIER: true + + # Common in both Node.js and ASP.NET projects + VALIDATE_EDITORCONFIG: true + # For Python, prefer the Ruff linter over Flake8 and isort. # The Ruff linter is faster than, has feature parity with, and serves as a drop-in replacement for both Flake8 and isort. # The Ruff formatter also has feature parity with Black, however Super-linter does not yet support the Ruff formatter. # Ref: https://docs.astral.sh/ruff/ - VALIDATE_PYTHON_FLAKE8: false - VALIDATE_PYTHON_ISORT: false - # Terrascan is not actively maintained, which results in outdated errors. - # For example, if using the nullable argument in a Terraform variable block, Terrascan throws an error. - # This argument was added in Terraform v1.1 (ref: https://developer.hashicorp.com/terraform/language/values/variables#disallowing-null-input-values). - VALIDATE_TERRAFORM_TERRASCAN: false - # Don't create status checks per linter. - # Create GitHub Actions job summary instead. - MULTI_STATUS: false - ENABLE_GITHUB_ACTIONS_STEP_SUMMARY: true + VALIDATE_PYTHON_RUFF: true + VALIDATE_PYTHON_RUFF_FORMAT: true + VALIDATE_PYTHON_MYPY: true + + VALIDATE_BASH: true + + VALIDATE_POWERSHELL: true + + VALIDATE_GITHUB_ACTIONS: true + VALIDATE_GITHUB_ACTIONS_ZIZMOR: true + + VALIDATE_TERRAFORM_FMT: true + VALIDATE_TERRAFORM_TFLINT: true + + VALIDATE_JSON: true + VALIDATE_YAML: true + + VALIDATE_MARKDOWN: true From adb801fd342e4056d912af8b38bdadf6bda182ec Mon Sep 17 00:00:00 2001 From: Henrik Knutsen <46495473+hknutsen@users.noreply.github.com> Date: Fri, 7 Nov 2025 08:38:16 +0100 Subject: [PATCH 2/5] Reduce number of enabled linters --- .github/workflows/super-linter.yml | 27 ++++----------------------- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/.github/workflows/super-linter.yml b/.github/workflows/super-linter.yml index c4b93ea0..6d473e94 100644 --- a/.github/workflows/super-linter.yml +++ b/.github/workflows/super-linter.yml @@ -50,26 +50,11 @@ jobs: # If triggered by PR, only validate changed files. VALIDATE_ALL_CODEBASE: ${{ github.event_name != 'pull_request' }} - VALIDATE_CSHARP: true - VALIDATE_DOTNET_SLN_FORMAT_ANALYZERS: true - VALIDATE_DOTNET_SLN_FORMAT_STYLE: true - VALIDATE_DOTNET_SLN_FORMAT_WHITESPACE: true - - VALIDATE_HTML: true - - VALIDATE_CSS: true - - VALIDATE_JAVASCRIPT_ES: true - VALIDATE_JAVASCRIPT_PRETTIER: true - VALIDATE_TYPESCRIPT_ES: true - VALIDATE_TYPESCRIPT_PRETTIER: true - # Common in both Node.js and ASP.NET projects VALIDATE_EDITORCONFIG: true - # For Python, prefer the Ruff linter over Flake8 and isort. - # The Ruff linter is faster than, has feature parity with, and serves as a drop-in replacement for both Flake8 and isort. - # The Ruff formatter also has feature parity with Black, however Super-linter does not yet support the Ruff formatter. + # For Python, prefer the Ruff linter and code formatter over Flake8, isort and Black. + # The Ruff linter and code formatter is faster than, has feature parity with, and serves as a drop-in replacement for Flake8, isort and Black. # Ref: https://docs.astral.sh/ruff/ VALIDATE_PYTHON_RUFF: true VALIDATE_PYTHON_RUFF_FORMAT: true @@ -79,13 +64,9 @@ jobs: VALIDATE_POWERSHELL: true - VALIDATE_GITHUB_ACTIONS: true - VALIDATE_GITHUB_ACTIONS_ZIZMOR: true - - VALIDATE_TERRAFORM_FMT: true - VALIDATE_TERRAFORM_TFLINT: true - VALIDATE_JSON: true VALIDATE_YAML: true VALIDATE_MARKDOWN: true + + VALIDATE_GITHUB_ACTIONS: true From 824d990cf8a5d9e50b8acc0a2e1184f5f7524075 Mon Sep 17 00:00:00 2001 From: Henrik Knutsen <46495473+hknutsen@users.noreply.github.com> Date: Fri, 7 Nov 2025 08:38:50 +0100 Subject: [PATCH 3/5] refactor --- .github/workflows/super-linter.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/super-linter.yml b/.github/workflows/super-linter.yml index 6d473e94..9f0bafa8 100644 --- a/.github/workflows/super-linter.yml +++ b/.github/workflows/super-linter.yml @@ -41,15 +41,13 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} FILTER_REGEX_EXCLUDE: ${{ inputs.filter_regex_exclude }} FILTER_REGEX_INCLUDE: ${{ inputs.filter_regex_include }} - + # If triggered by PR, only validate changed files. + VALIDATE_ALL_CODEBASE: ${{ github.event_name != 'pull_request' }} # Don't create status checks per linter. # Create GitHub Actions job summary instead. MULTI_STATUS: false ENABLE_GITHUB_ACTIONS_STEP_SUMMARY: true - # If triggered by PR, only validate changed files. - VALIDATE_ALL_CODEBASE: ${{ github.event_name != 'pull_request' }} - # Common in both Node.js and ASP.NET projects VALIDATE_EDITORCONFIG: true From 303732354fe6f27d8ac87ecca71fe1229d5f66bc Mon Sep 17 00:00:00 2001 From: Henrik Knutsen <46495473+hknutsen@users.noreply.github.com> Date: Fri, 7 Nov 2025 08:41:08 +0100 Subject: [PATCH 4/5] docs --- .github/workflows/super-linter.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/super-linter.yml b/.github/workflows/super-linter.yml index 9f0bafa8..d9e60785 100644 --- a/.github/workflows/super-linter.yml +++ b/.github/workflows/super-linter.yml @@ -51,8 +51,9 @@ jobs: # Common in both Node.js and ASP.NET projects VALIDATE_EDITORCONFIG: true - # For Python, prefer the Ruff linter and code formatter over Flake8, isort and Black. - # The Ruff linter and code formatter is faster than, has feature parity with, and serves as a drop-in replacement for Flake8, isort and Black. + # For Python, prefer the Ruff linter and code formatter over Flake8, + # isort and Black. Ruff is faster than, has feature parity with, and + # serves as a drop-in replacement for these tools. # Ref: https://docs.astral.sh/ruff/ VALIDATE_PYTHON_RUFF: true VALIDATE_PYTHON_RUFF_FORMAT: true From 425cdf3a2e0118ebeebbeac5d7f4c6fdcee13744 Mon Sep 17 00:00:00 2001 From: Henrik Knutsen <46495473+hknutsen@users.noreply.github.com> Date: Mon, 10 Nov 2025 07:49:44 +0100 Subject: [PATCH 5/5] refactor --- .github/workflows/super-linter.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/super-linter.yml b/.github/workflows/super-linter.yml index d9e60785..f5380205 100644 --- a/.github/workflows/super-linter.yml +++ b/.github/workflows/super-linter.yml @@ -48,19 +48,14 @@ jobs: MULTI_STATUS: false ENABLE_GITHUB_ACTIONS_STEP_SUMMARY: true - # Common in both Node.js and ASP.NET projects - VALIDATE_EDITORCONFIG: true - # For Python, prefer the Ruff linter and code formatter over Flake8, # isort and Black. Ruff is faster than, has feature parity with, and # serves as a drop-in replacement for these tools. # Ref: https://docs.astral.sh/ruff/ VALIDATE_PYTHON_RUFF: true VALIDATE_PYTHON_RUFF_FORMAT: true - VALIDATE_PYTHON_MYPY: true VALIDATE_BASH: true - VALIDATE_POWERSHELL: true VALIDATE_JSON: true