Updated Code: handles zero devices, tests with vcr, extracted duplicated code into private methods #29
Conversation
mark-smithtb
commented
Nov 16, 2015
mark-smithtb
commented
- pulled post to device out of temperature methods into a private method.
- refactored to only pull structor and device ids if they exist.
- Added vcr to record interactions with the nest api for testing.
- Added timecop to freeze time for sets away status test to work with vcr.
|
Whoa. |
There was a problem hiding this comment.
You might want to change your password. Also this shouldn't be in the repo. :D
|
Could we put the fixtures in /spec/fixtures instead of /fixtures? Side note: We should set up circleci (or travis) and hound on this project. |
spec/spec_helper.rb
Outdated
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/nest_thermostat_spec.rb
Outdated
There was a problem hiding this comment.
Line is too long. [99/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
lib/nest_thermostat/nest.rb
Outdated
There was a problem hiding this comment.
Surrounding space missing for operator ||.
|
Looks like a few more hound violations. Also, could you pull in master, circleci should be fixed. |
There was a problem hiding this comment.
Do not use Time.local without zone. Use one of Time.zone.local, Time.local.current, Time.local.in_time_zone, Time.local.utc, Time.local.getlocal, Time.local.iso8601, Time.local.jisx0301, Time.local.rfc3339, Time.local.to_i, Time.local.to_f instead.
"pulling master in from upstream"
4 participants
