Add Symfony ruleset in ECS

Author: erichard

ecs.php

@@ -11,10 +11,11 @@
     $containerConfigurator->import(SetList::SYMPLIFY);
     $containerConfigurator->import(SetList::COMMON);
     $containerConfigurator->import(SetList::CLEAN_CODE);
+    $containerConfigurator->import(SetList::SYMFONY);
 
     $parameters = $containerConfigurator->parameters();
 
     $parameters->set(Option::PARALLEL, true);
 
-    $parameters->set(Option::PATHS, [__DIR__ . '/src', __DIR__ . '/tests', __DIR__ . '/ecs.php']);
+    $parameters->set(Option::PATHS, [__DIR__.'/src', __DIR__.'/tests', __DIR__.'/ecs.php']);
 };

src/Aggregation/CardinalityAggregation.php

@@ -42,7 +42,7 @@ protected function buildAggregation(): array
     {
         $build = parent::buildAggregation();
 
-        if ($this->precisionThreshold !== null) {
+        if (null !== $this->precisionThreshold) {
             $build['precision_threshold'] = $this->precisionThreshold;
         }
 

src/Aggregation/MetricAggregation.php

@@ -26,7 +26,7 @@ public function __construct(
     ) {
         parent::__construct($nameAndField, $aggregations);
 
-        if ($fieldOrSource === null) {
+        if (null === $fieldOrSource) {
             $fieldOrSource = $nameAndField;
         }
 
@@ -72,13 +72,13 @@ public function setMissing(?int $missing): self
     protected function buildAggregation(): array
     {
         $term = [];
-        if ($this->script !== null) {
+        if (null !== $this->script) {
             $term = $this->script->build();
-        } elseif ($this->field !== null) {
+        } elseif (null !== $this->field) {
             $term = $this->field->build();
         }
 
-        if ($this->missing !== null) {
+        if (null !== $this->missing) {
             $term['missing'] = $this->missing;
         }
 

src/Aggregation/RangesAggregation.php

@@ -14,12 +14,12 @@ class RangesAggregation extends AbstractAggregation
      * Builds automatically range aggregation with simple ranges array of numeric.
      *
      * @param array<int>                 $ranges                  pass desired ranges that will be converted to
-     * linear range
+     *                                                            linear range
      * @param array<AbstractAggregation> $aggregations
      * @param bool                       $equalConditionOnToRange Se to true if you want to do a histogram with 0
-     * - 10, 10 - 15, and correctly count the number
-     * (entry with 10 will be in first and seconds
-     * segment
+     *                                                            - 10, 10 - 15, and correctly count the number
+     *                                                            (entry with 10 will be in first and seconds
+     *                                                            segment
      */
     public function __construct(
         string $name,
@@ -65,7 +65,7 @@ protected function buildAggregation(): array
 
         // Append "others"
         $ranges[] = [
-            'key' => $prevValue . '-*',
+            'key' => $prevValue.'-*',
             'from' => $prevValue,
         ];
 

src/Aggregation/TermsAggregation.php

@@ -76,27 +76,27 @@ public function setExclude(array|string|null $exclude): self
     protected function buildAggregation(): array
     {
         $build = [];
-        if ($this->script !== null) {
+        if (null !== $this->script) {
             $build = [
                 'script' => $this->script->build(),
             ];
-        } elseif ($this->field !== null) {
+        } elseif (null !== $this->field) {
             $build = $this->field->build() + [
                 'size' => $this->size,
             ];
         }
 
-        if ($this->orderField !== null) {
+        if (null !== $this->orderField) {
             $build['order'] = [
                 $this->orderField => $this->orderValue,
             ];
         }
 
-        if ($this->include !== null) {
+        if (null !== $this->include) {
             $build['include'] = $this->include;
         }
 
-        if ($this->exclude !== null) {
+        if (null !== $this->exclude) {
             $build['exclude'] = $this->exclude;
         }
 

src/Aggregation/TopHitsAggregation.php

@@ -39,7 +39,7 @@ protected function buildAggregation(): array
             'size' => $this->size,
         ];
 
-        if ($this->script !== null) {
+        if (null !== $this->script) {
             $data['_source'] = [
                 'includes' => $this->script,
             ];

src/Features/HasAggregations.php

@@ -40,7 +40,7 @@ public function getAggregations(): ?array
 
     protected function buildAggregationsTo(array &$toArray): self
     {
-        if (count($this->aggregations) === 0) {
+        if (0 === count($this->aggregations)) {
             return $this;
         }
 

src/Features/HasCollapse.php

@@ -36,7 +36,7 @@ public function getCollapse(): ?Collapse
      */
     protected function buildCollapseTo(array &$toArray): self
     {
-        if ($this->collapse !== null) {
+        if (null !== $this->collapse) {
             $toArray['collapse'] = $this->collapse->build();
         }
 

src/Features/HasOperator.php

@@ -17,7 +17,7 @@ public function setOperator(?string $operator): self
 
     public function buildOperatorTo(array &$array): self
     {
-        if ($this->operator === null) {
+        if (null === $this->operator) {
             return $this;
         }
 

src/Features/HasSorting.php

@@ -32,7 +32,7 @@ public function addSort(string $field, string|array $config = SortDirections::AS
      */
     protected function buildSortTo(array &$toArray): self
     {
-        if (empty($this->sort) === false) {
+        if (false === empty($this->sort)) {
             foreach ($this->sort as $sort => $config) {
                 $toArray['sort'][$sort] = $config;
             }