Replace ECS by php-cs-fixer

Author: erichard

.gitignore

@@ -2,3 +2,4 @@ vendor
 composer.lock
 .phpunit.result.cache
 .editorconfig
+.php-cs-fixer.cache

.php_cs.dist.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types=1);
+
+$finder = PhpCsFixer\Finder::create()
+    ->in(__DIR__ . '/src')
+    ->exclude(__DIR__ . '/tests')
+;
+
+return (new PhpCsFixer\Config())
+    ->registerCustomFixers(new PhpCsFixerCustomFixers\Fixers())
+    ->setRiskyAllowed(true)
+    ->setRules([
+        '@PSR12' => true,
+        '@PSR12:risky' => true,
+        '@Symfony' => true,
+        '@Symfony:risky' => true,
+        'linebreak_after_opening_tag' => true,
+        'mb_str_functions' => true,
+        'no_php4_constructor' => true,
+        'no_unreachable_default_argument_value' => true,
+        'no_useless_else' => true,
+        'no_useless_return' => true,
+        'php_unit_strict' => true,
+        'phpdoc_order' => true,
+        'strict_comparison' => true,
+        'strict_param' => true,
+        'concat_space' => false,
+        'declare_strict_types' => true,
+        'native_function_invocation' => ['include' => []],
+        PhpCsFixerCustomFixers\Fixer\DeclareAfterOpeningTagFixer::name() => true,
+        PhpCsFixerCustomFixers\Fixer\NoDoctrineMigrationsGeneratedCommentFixer::name() => true,
+        PhpCsFixerCustomFixers\Fixer\NoImportFromGlobalNamespaceFixer::name() => true,
+        PhpCsFixerCustomFixers\Fixer\PromotedConstructorPropertyFixer::name() => true,
+        PhpCsFixerCustomFixers\Fixer\ConstructorEmptyBracesFixer::name() => true,
+        PhpCsFixerCustomFixers\Fixer\MultilinePromotedPropertiesFixer::name() => true,
+        PhpCsFixerCustomFixers\Fixer\NoUselessDoctrineRepositoryCommentFixer::name() => true,
+    ])
+    ->setFinder($finder)
+;

composer.json

@@ -31,10 +31,9 @@
         "symplify/easy-coding-standard": "^10.1"
     },
     "scripts": {
-        "lint:fix": "./vendor/bin/ecs --fix --clear-cache --no-progress-bar",
+        "lint:fix": "php tools/php-cs-fixer/vendor/bin/php-cs-fixer fix --config=./.php_cs.dist.php",
         "lint:stan": "./vendor/bin/phpstan",
-        "lint:upgrade": "vendor/bin/rector process",
-        "lint": "composer lint:fix && composer lint:upgrade && composer lint:stan",
+        "lint": "composer lint:fix && composer lint:stan",
         "test": "./vendor/bin/phpunit"
     },
     "extra": {

ecs.php

@@ -1,6 +1,4 @@
-<?php
-
-declare(strict_types=1);
+<?php declare(strict_types=1);
 
 namespace Erichard\ElasticQueryBuilder\Aggregation;
 

rector.php

@@ -1,6 +1,4 @@
-<?php
-
-declare(strict_types=1);
+<?php declare(strict_types=1);
 
 namespace Erichard\ElasticQueryBuilder\Aggregation;
 

src/Aggregation/AbstractAggregation.php

@@ -1,6 +1,4 @@
-<?php
-
-declare(strict_types=1);
+<?php declare(strict_types=1);
 
 namespace Erichard\ElasticQueryBuilder\Aggregation;
 

src/Aggregation/Aggregation.php

@@ -1,6 +1,4 @@
-<?php
-
-declare(strict_types=1);
+<?php declare(strict_types=1);
 
 namespace Erichard\ElasticQueryBuilder\Aggregation;
 
@@ -12,8 +10,8 @@
  */
 class DateHistogramAggregation extends AbstractAggregation
 {
-    use HasField;
-    use HasExtendedBounds; // TODO enum
+    use HasExtendedBounds;
+    use HasField; // TODO enum
 
     /**
      * @param array<AbstractAggregation> $aggregations

src/Aggregation/CardinalityAggregation.php

@@ -1,6 +1,4 @@
-<?php
-
-declare(strict_types=1);
+<?php declare(strict_types=1);
 
 namespace Erichard\ElasticQueryBuilder\Aggregation;