Skip to content

Changes Now Playing entry on main menu ... but doesn't reverse if user changes back to default #2

@pcosway

Description

@pcosway

This is not a big issue, but I'm putting the information here in case anyone updates this code in the future.

The function _installCustomNowPlaying changes the Now Playing entry in the main menu.

Line 1058 currently reads: self:goNowPlaying(Window.transitionPushLeft)

It should be changed to read: appletManager:callService("goNowPlaying",Window.transitionPushLeft)

With this change, if the user reverts to the default Now Playing, the menu entry will use that (by looking up goNowPlaying).

This only matters between the time the user reverts to default and the next reboot of the device, but if anyone is ever changing the code this would be a good change!

I have submitted a PR for NowPlayingApplet to make the default menu entry also use callService. When that change is made, there is no need for _installCustomNowPlaying at all.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions