Skip to content

Commit 0f20912

Browse files
Fix: unable to render conversionsApiDataLayer directive without arguments
1 parent ca8fde8 commit 0f20912

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

src/ConversionsApiServiceProvider.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,11 @@ public function register()
2626
protected function registerBladeDirectives(): void
2727
{
2828
Blade::directive('conversionsApiDataLayer', function (?string $dataLayerVariableName = null) {
29-
return "<?php echo view('conversions-api::data-layer', ['dataLayerVariableName' => {$dataLayerVariableName}]); ?>";
29+
if (! $dataLayerVariableName) {
30+
return "<?php echo view('conversions-api::data-layer'); ?>";
31+
}
32+
33+
return "<?php echo view('conversions-api::data-layer', ['dataLayerVariableName' => $dataLayerVariableName]); ?>";
3034
});
3135
Blade::directive('conversionsApiFacebookPixelScript', function () {
3236
return "<?php echo view('conversions-api::facebook-pixel-script'); ?>";

tests/ConversionsApiViewTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,4 +77,13 @@ public function it_can_render_the_data_layer_directive()
7777
Blade::compileString("@conversionsApiDataLayer('customDataLayerVariableName')"),
7878
);
7979
}
80+
81+
/** @test */
82+
public function it_can_render_the_data_layer_directive_when_no_arguments_are_provided()
83+
{
84+
$this->assertStringContainsString(
85+
"<?php echo view('conversions-api::data-layer'); ?>",
86+
Blade::compileString("@conversionsApiDataLayer"),
87+
);
88+
}
8089
}

0 commit comments

Comments
 (0)