-
Notifications
You must be signed in to change notification settings - Fork 146
Suppress resolving addresses for 1st stage bootloader output #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Chip::Esp32 => { | ||
| if let Some((major, _)) = self.revision { | ||
| if major >= 3 { | ||
| if let Some((_, minor)) = self.revision { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are needed after fixing the efuse reading (in a previous PR) - I just noticed it when working on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only one minor nitpick comment! Also, I found out that format was weird:
espflash on suppress-rom-bootloader-address-resolving [$] via 🦀 v1.93.0-nightly took 3s
❯ cargo r -r --bin espflash flash espflash/tests/data/esp32c3 --monitor --all-addresses --no-addresses
...
[2025-11-28T11:50:18Z INFO ] Flashing has completed!
Commands:
CTRL+R Reset chip
CTRL+C Exit
[2025-11-28T11:50:18Z WARN ] Suppressing address resolution with `--all-addresses` given
ESP-ROM:esp32c3-api1-20210207
Build:Feb 7 2021
rst:0x15 (USB_UART_CHIP_RESET),boot:0xc (SPI_FAST_FLASH_BOOT)
Saved PC:0x40380862
SPIWP:0xee
mode:DIO, clock div:2
load:0x3fcd5820,len:0x15c4
load:0x403cbf10,len:0xc84
load:0x403ce710,len:0x2fd0
entry 0x403cbf1a
See the ESP-ROM:esp32c3-api1-20210207
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
|
Thanks! I cannot repro that weird formatting (probably because I'm on Windows) - hopefully my maybe-fix is working |
It made things a bit better: With With But not sure if its worth adjusting to my terminal output as we didnt test others setups. |
Closes #977
Just in case this also adds an option to fall back to the previous behavior but in general I'd say this should help to not scare new users and reduce noise for seasoned users