multiple Calibration dialogs open after USB disconnect/connect while executing calibration

[mi-hol]

PROBLEM DESCRIPTION

Calibration is not protected against multiple activation during a pending calibration

REQUESTED INFORMATION

• Verified with latest published Labrador version

• Searched the problem in the Troubleshooting Guide

• Searched the problem in the docs

• Searched the problem in issues

• Searched the problem in discussions

• Hardware the software is running on: "System Type: x64-based PC"

• Operating System (OS) Build Version: "OS Name: "Microsoft Windows 11 Home" & "OS Version: 25H2 (Build: 26200.7462)" & "OS Configuration: Standalone Workstation")

• Labrador Git hash: 572b557

TO REPRODUCE

Steps to reproduce the behavior:
i.e.:

1. Go to menu 'Oscilloscope'
2. Click on 'Calibrate'
3. get calibration dialog
4. disconnect USB cable, then connect USB cable
5. repeat from 3.

EXPECTED BEHAVIOUR

Only a single calibration dialog while calibration was started but not completed yet

SCREENSHOTS

3 dialogs are open but only one visible due to stacked windows of same size

ADDITIONAL CONTEXT

was fixed for Android in #376
Likely this needs the same approach for all platforms

[brentfpage]

Edit: I read the title of the post again and now better understand. This could very well happen on mac as well, and I'll look into fixing it.

This might have been caused by the changes in #376. I tested #376 on mac and android, but that obviously wasn't enough. Just to make sure, the "Please connect ... to the Power Supply..." dialog box comes up in front of the previous "Please connect ... the USB connector..." box when the USB shield is touched?

Each command

calibrationMessages->exec();

"shows the message box as a modal dialog, blocking until the user closes it."
These commands are run after every dialog box is shown, so I'm surprised it's possible for several of them to be shown at the same time.

[mi-hol]

Just to make sure, the "Please connect ... to the Power Supply..." dialog box comes up in front of the previous "Please connect ... the USB connector..." box when the USB shield is touched?

I found the reason for the USB disconnect/connect events to be a broken cable wire just after the MicroUSB connector. When I touched the USB ground, the cable got bent just enough to trigger it.
Therefore this is very likely not a new error but the same race condition(s) as described in #333 (comment)

[freshLobster]

hey @mi-hol assign it to me and I'll make sure to look out for this in my windows patch for #333 which is almost ready for a new PR