Skip to content

Harmony should start EthereumJ only by request #119

@zilm13

Description

@zilm13

Currently EthereumJ automatically starts with start of Harmony and this behaviour follows growing number of hacks to run Harmony as desired:

  1. Harmony config is added to ethereum.conf.res so it could be overwritten by other configs
  2. Miner is disabled on start even if it's enabled in config and started a bit later in MinerService

Fundamental improvements in EthereumJ are needed to fix it but most of them are planned and will enhance EthereumJ usage as library and improve Harmony code quality:

  1. Disable triggering of config load by static methods Usage of static methods shouldn't trigger config load ethereum/ethereumj#1012
  2. Detach EthereumJ to separate ApplicationContext in Harmony
  3. Build config for EthereumJ from code and instantiate it with this config, there should be an option in EthereumJ when it doesn't try to read config at all and starts with input config EthereumJ Config Builder ethereum/ethereumj#469
  4. Don't use beans from EthereumJ by Autowired in Harmony. Instead improve EthereumJ to provide any of this beans from some facade and we should use it that way in Harmony.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions