-
Notifications
You must be signed in to change notification settings - Fork 89
Harmony should start EthereumJ only by request #119
Copy link
Copy link
Open
Description
Currently EthereumJ automatically starts with start of Harmony and this behaviour follows growing number of hacks to run Harmony as desired:
- Harmony config is added to
ethereum.conf.resso it could be overwritten by other configs - Miner is disabled on start even if it's enabled in config and started a bit later in MinerService
Fundamental improvements in EthereumJ are needed to fix it but most of them are planned and will enhance EthereumJ usage as library and improve Harmony code quality:
- Disable triggering of config load by static methods Usage of static methods shouldn't trigger config load ethereum/ethereumj#1012
- Detach EthereumJ to separate ApplicationContext in Harmony
- Build config for EthereumJ from code and instantiate it with this config, there should be an option in EthereumJ when it doesn't try to read config at all and starts with input config EthereumJ Config Builder ethereum/ethereumj#469
- Don't use beans from EthereumJ by
Autowiredin Harmony. Instead improve EthereumJ to provide any of this beans from some facade and we should use it that way in Harmony.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels