From e5163a5ee2aad66dd0da8a854962be4bafd53448 Mon Sep 17 00:00:00 2001 From: John McLear Date: Thu, 30 Apr 2026 06:06:51 +0100 Subject: [PATCH] test(playwright): un-skip ep_headings2 spec under WITH_PLUGINS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the FRONTEND_IGNORE entry that suppressed ep_headings2/static/tests/frontend-new/specs/headings.spec.ts under WITH_PLUGINS=1. The skip was added in #7628 while the keystroke-drop flake (#7611) was still being chased; #7630 then identified the actual root cause as ep_cursortrace's per-keystroke cursorPosition socket spam saturating Firefox's input pipeline, removed ep_cursortrace from the WITH_PLUGINS plugin set, and added waitForEditorReady() to goToNewPad/goToPad. With both root causes addressed, this skip is likely stale — the spec's own "Option select is changed when heading is changed" test already uses insertText for the second-line typing, so it should clear the same bar that #7630 cleared for ep_markdown and ep_spellcheck (both now passing on develop). Closes ether/etherpad#7626 if CI confirms — the issue's three plugin specs (markdown, spellcheck, headings2) and timeslider_identity_changeset are all addressed once this lands. If headings2 is still flaky after this, FRONTEND_IGNORE comes back with a narrower comment about what specifically still races. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/playwright.config.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/playwright.config.ts b/src/playwright.config.ts index c75cb131332..3a7de8f35eb 100644 --- a/src/playwright.config.ts +++ b/src/playwright.config.ts @@ -20,14 +20,7 @@ const PLUGIN_SPECS = [ ]; const FRONTEND_MATCH = [CORE_SPECS, ...PLUGIN_SPECS]; -// Vendored plugin specs we can't edit that are flaky under the WITH_PLUGINS -// firefox run (keystrokes drop when the /ether plugin set is loaded). Skip -// only when WITH_PLUGINS=1 so the standalone plugin runs still cover them. -// Tracking issue: #7611. Mirror of the `test.skip(WITH_PLUGINS)` pattern -// used in our own core specs. -const FRONTEND_IGNORE = process.env.WITH_PLUGINS === '1' ? [ - '**/ep_headings2*/static/tests/frontend-new/specs/headings.spec.ts', -] : []; +const FRONTEND_IGNORE: string[] = []; /** * See https://playwright.dev/docs/test-configuration.