umkpasswd on illumos: segmentation fault

[janicez]

(gdb) run -m smd5 555
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /home/ellenor/src/evilnet/nefarious2/ircd/umkpasswd -m smd5 555
[Thread debugging using libthread_db enabled]
[New Thread 1 (LWP 1)]

Thread 2 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1 (LWP 1)]
make_salt (salts=0x408df8 "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789./") at umkpasswd.c:132
132       memcpy(tmp, (salts+n), 1);

from another invocation:

(gdb) print tmp
$1 = 0xc7a930 ""
(gdb) print salts
$2 = 0x408df8 "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789./"
(gdb) print n
$3 = 3040655

[janicez]

Jobe said that this bug should be reported to the Undernet team. I am not able to do this for various reasons.

[janicez]

--- a/ircd/umkpasswd.c
+++ b/ircd/umkpasswd.c
@@ -128,10 +128,10 @@ long int n = 0;
  if((tmp = calloc(3, sizeof(char))) != NULL)
  {
   /* can't optimize this much more than just doing it twice */
-  n = ((float)(strlen(salts))*random()/(RAND_MAX+1.0));
+  n = (int)(((float)(strlen(salts))*arc4random()/(RAND_MAX+1.0)))%64;
   memcpy(tmp, (salts+n), 1);
   sleep(2);
-  n = ((float)(strlen(salts))*random()/(RAND_MAX+1.0));
+  n = (int)(((float)(strlen(salts))*arc4random()/(RAND_MAX+1.0)))%64;
   memcpy((tmp+1), (salts+n), 1);
 
   Debug((DEBUG_DEBUG, "salts = %s", salts));

This works around the bug. I'm not sure it fixes it though.